The Wayback Machine - https://web.archive.org/web/20210916151711/https://github.com/angular/components/pull/20257
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update reviews guide to remove lgtm label #20257

Merged
merged 1 commit into from Aug 12, 2020

Conversation

@crisbeto
Copy link
Member

@crisbeto crisbeto commented Aug 10, 2020

The reviews guide was referring to the lgtm label which was removed recently.

The reviews guide was referring to the `lgtm` label which was removed recently.
Copy link
Member

@josephperrott josephperrott left a comment

LGTM

@andrewseguin andrewseguin merged commit 9425ae5 into angular:master Aug 12, 2020
15 checks passed
15 checks passed
@ngbot[bot]
ci/angular: merge status All checks passed!
ci/circleci: api_golden_checks Your tests passed on CircleCI!
Details
ci/circleci: bazel_build Your tests passed on CircleCI!
Details
ci/circleci: build_release_packages Your tests passed on CircleCI!
Details
ci/circleci: e2e_tests Your tests passed on CircleCI!
Details
ci/circleci: integration_tests Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: ngcc_compatibility Your tests passed on CircleCI!
Details
ci/circleci: tests_browserstack Your tests passed on CircleCI!
Details
ci/circleci: tests_local_browsers Your tests passed on CircleCI!
Details
ci/circleci: tests_saucelabs Your tests passed on CircleCI!
Details
ci/circleci: upload_release_packages Your tests passed on CircleCI!
Details
ci/circleci: view_engine_build Your tests passed on CircleCI!
Details
ci/circleci: view_engine_test Your tests passed on CircleCI!
Details
@googlebot
cla/google All necessary CLAs are signed
andrewseguin added a commit that referenced this issue Aug 12, 2020
The reviews guide was referring to the `lgtm` label which was removed recently.

(cherry picked from commit 9425ae5)
@angular-automatic-lock-bot
Copy link

@angular-automatic-lock-bot angular-automatic-lock-bot bot commented Sep 12, 2020

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 12, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants