The Wayback Machine - https://web.archive.org/web/20211108185833/https://github.com/tensorflow/tensorflow/pull/51733
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix tf.math.segment_max/min/mean/sun/prod crashes(aborts) when segment_ids is large #51733

Merged
merged 2 commits into from Oct 28, 2021
Merged

Fix tf.math.segment_max/min/mean/sun/prod crashes(aborts) when segment_ids is large #51733

merged 2 commits into from Oct 28, 2021

Conversation

Reviewers

@sanjoy sanjoy

@mihaimaruseac mihaimaruseac

Assignees

@gbaned gbaned

Labels
cla: yes comp:ops prtype:bugfix size:S
Projects
PR Queue
  
Reviewer Requested Changes
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

tf.math.segment_max/min/mean/sun/prod crashes(aborts) when segment_ids is large
6 participants
@yongtang @sanjoy @mihaimaruseac @kokoro-team @tensorflowbutler @gbaned
@yongtang
Copy link
Member

@yongtang yongtang commented Aug 28, 2021

This PR fixes the issue raised in #46888 where tf.math.segment_max/min/mean/sun/prod crashes(aborts) when segment_ids is large.

This PR fixes #46888.

Signed-off-by: Yong Tang [email protected]
yongtang added 2 commits Aug 28, 2021
@yongtang
Fix tf.math.segment_max/min/mean/sun/prod crashes(aborts) when segmen…
2b6e3c5 
…t_ids is large

This PR fixes the issue raised in 46888 where
tf.math.segment_max/min/mean/sun/prod crashes(aborts) when segment_ids is large.

This PR fixes 46888.

Signed-off-by: Yong Tang <[email protected]>
@yongtang
Add test case for GitHub isseu 46888.
ab5a569 
Signed-off-by: Yong Tang <[email protected]>
@google-cla google-cla bot added the cla: yes label Aug 28, 2021
@yongtang yongtang requested review from mihaimaruseac and sanjoy Aug 28, 2021
@yongtang yongtang mentioned this pull request Aug 28, 2021
Closed
@gbaned gbaned self-assigned this Aug 30, 2021
@gbaned gbaned added this to Assigned Reviewer in PR Queue via automation Aug 30, 2021
PR Queue automation moved this from Assigned Reviewer to Approved by Reviewer Aug 30, 2021
sanjoy
sanjoy requested changes Aug 31, 2021
View changes
tensorflow/core/kernels/segment_reduction_ops_impl.h Show resolved Hide resolved
Loading
tensorflow/core/kernels/segment_reduction_ops_impl.h Show resolved Hide resolved
Loading
PR Queue automation moved this from Approved by Reviewer to Reviewer Requested Changes Aug 31, 2021
mihaimaruseac
mihaimaruseac approved these changes Oct 27, 2021
View changes
tensorflow/core/kernels/segment_reduction_ops_impl.h Show resolved Hide resolved
Loading
tensorflow/core/kernels/segment_reduction_ops_impl.h Show resolved Hide resolved
Loading
@copybara-service copybara-service bot merged commit e9c81c1 into tensorflow:master Oct 28, 2021
10 of 15 checks passed
Loading
pranve added a commit to pranve/tensorflow that referenced this issue Oct 28, 2021
@tensorflower-gardener @pranve
Merge pull request tensorflow#51733 from yongtang:46888-tf.math.segment_
4dd50e5 
PiperOrigin-RevId: 406020083
Change-Id: I179a9a8fe548ed324fc97363e81a46be28aa19b8
pranve added a commit to pranve/tensorflow that referenced this issue Oct 28, 2021
@tensorflower-gardener @pranve
Merge pull request tensorflow#51733 from yongtang:46888-tf.math.segment_
74445a2 
PiperOrigin-RevId: 406020083
Change-Id: I179a9a8fe548ed324fc97363e81a46be28aa19b8
pranve added a commit to pranve/tensorflow that referenced this issue Oct 28, 2021
@tensorflower-gardener @pranve
Merge pull request tensorflow#51733 from yongtang:46888-tf.math.segment_
d8bc8f1 
PiperOrigin-RevId: 406020083
Change-Id: I179a9a8fe548ed324fc97363e81a46be28aa19b8
mihaimaruseac added a commit that referenced this issue Oct 28, 2021
@mihaimaruseac
Merge pull request #52798 from pranve/cherrypick-e9c81c1e1a9cd8dd31f4…
dd68305 
…e83676cab61b60658429-on-r2.6

Merge pull request #51733 from yongtang:46888-tf.math.segment_
mihaimaruseac added a commit that referenced this issue Oct 28, 2021
@mihaimaruseac
Merge pull request #52799 from pranve/cherrypick-e9c81c1e1a9cd8dd31f4…
4376767 
…e83676cab61b60658429-on-r2.5

Merge pull request #51733 from yongtang:46888-tf.math.segment_
mihaimaruseac added a commit that referenced this issue Oct 28, 2021
@mihaimaruseac
Merge pull request #52800 from pranve/cherrypick-e9c81c1e1a9cd8dd31f4…
dca1d97 
…e83676cab61b60658429-on-r2.4

Merge pull request #51733 from yongtang:46888-tf.math.segment_
mihaimaruseac added a commit that referenced this issue Oct 28, 2021
@tensorflower-gardener @mihaimaruseac
Merge pull request #51733 from yongtang:46888-tf.math.segment_
2aebcb8 
PiperOrigin-RevId: 406020083
Change-Id: I179a9a8fe548ed324fc97363e81a46be28aa19b8
mihaimaruseac added a commit that referenced this issue Oct 28, 2021
@mihaimaruseac
Merge pull request #52840 from tensorflow/mm-cp-pr-on-r2.7
2a68316 
Merge pull request #51733 from yongtang:46888-tf.math.segment_
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment