-
Notifications
You must be signed in to change notification settings - Fork 28.7k
Make NavigationRail scrollable #89271
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…scroll-navigation-rail
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat. If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
I am kind of not sure what tests would we write for this PR, some sort of feedback or pointers would be much helpful. Thanks |
So, a possible test would be to create a NavigationRail, and then synthesize a drag over the control and verify that it scrolls. You'll also have to address the semantics failures in the existing tests. Ideally, the semantics tree wouldn't change, but since you are introducing scrolling, the semantics will change somewhat, and you'll have to verify that your changes are sensible. I also think perhaps that the semantics shouldn't change on a control that is too small to scroll, but perhaps there is overscroll even then, so maybe not (I'm not too sure about that point). |
…scroll-navigation-rail
This pull request executed golden file tests, but it has not been updated in a while (20+ days). Test results from Gold expire after as many days, so this pull request will need to be updated with a fresh commit in order to get results from Gold. For more guidance, visit Writing a golden file test for Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
Thanks for taking a look @gspencergoog, I am sorry for the delayed response, I have added the scrollable test. But I have no idea at this point how to address the semantics test failure Actual: SemanticsTester:<SemanticsTester for SemanticsNode#0(Rect.fromLTRB(0.0, 0.0, 2400.0, 1800.0))>
Which: expected node id null to have textDirection "TextDirection.ltr" but found "null".
Current SemanticsNode tree: Some feedback or pointers would be much helpful. |
@maheshmnj If you are still interested in working on this PR but looking for advice on writing the tests, I recommend reaching out for help on Discord in our #hackers-new channel. See the contributing guide for a link to the Discord server. Thanks! |
Closing this for now will send a PR When I can fully contribute |
any update on this issue? |
This PR addressed the issue #89167 to make the navigationRail Scrollable when the number NavigationDestinations exceeds the viewport
Pre-launch Checklist
///
).If you need help, consider asking for advice on the #hackers-new channel on Discord.