The Wayback Machine - https://web.archive.org/web/20210909071817/https://github.com/flutter/flutter/pull/89335
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix a DraggableScrollableSheet bug #89335

Merged
merged 2 commits into from Sep 9, 2021
Merged

Conversation

@xu-baolin
Copy link
Member

@xu-baolin xu-baolin commented Sep 2, 2021

Fixes #89214

We should release the animation controller before the scrollable widget dispose.

@google-cla google-cla bot added the cla: yes label Sep 2, 2021
@xu-baolin xu-baolin requested a review from Piinks Sep 2, 2021
Copy link
Member

@goderbauer goderbauer left a comment

LGTM

@fluttergithubbot fluttergithubbot merged commit cec1457 into flutter:master Sep 9, 2021
56 checks passed
56 checks passed
@flutter-github-sync
Google testing Google testing passed!
Details
@flutter-dashboard
Linux analyze
Details
@flutter-dashboard
Linux build_tests_1_2
Details
@flutter-dashboard
Linux build_tests_2_2
Details
@flutter-dashboard
Linux customer_testing
Details
@flutter-dashboard
Linux docs_test
Details
@flutter-dashboard
Linux firebase_abstract_method_smoke_test
Details
@flutter-dashboard
Linux firebase_android_embedding_v2_smoke_test
Details
@flutter-dashboard
Linux firebase_release_smoke_test
Details
@flutter-dashboard
Linux flutter_plugins
Details
@flutter-dashboard
Linux framework_tests_libraries
Details
@flutter-dashboard
Linux framework_tests_misc
Details
@flutter-dashboard
Linux framework_tests_widgets
Details
@flutter-dashboard
Linux fuchsia_precache
Details
@flutter-dashboard
Linux skp_generator
Details
@flutter-dashboard
Linux web_long_running_tests_1_5
Details
@flutter-dashboard
Linux web_long_running_tests_2_5
Details
@flutter-dashboard
Linux web_long_running_tests_3_5
Details
@flutter-dashboard
Linux web_long_running_tests_4_5
Details
@flutter-dashboard
Linux web_long_running_tests_5_5
Details
@flutter-dashboard
Linux web_tests_0
Details
@flutter-dashboard
Linux web_tests_1
Details
@flutter-dashboard
Linux web_tests_2
Details
@flutter-dashboard
Linux web_tests_3
Details
@flutter-dashboard
Linux web_tests_4
Details
@flutter-dashboard
Linux web_tests_5
Details
@flutter-dashboard
Linux web_tests_6
Details
@flutter-dashboard
Linux web_tests_7_last
Details
@flutter-dashboard
Mac build_tests_1_4
Details
@flutter-dashboard
Mac build_tests_2_4
Details
@flutter-dashboard
Mac build_tests_3_4
Details
@flutter-dashboard
Mac build_tests_4_4
Details
@flutter-dashboard
Mac customer_testing
Details
@flutter-dashboard
Mac framework_tests_libraries
Details
@flutter-dashboard
Mac framework_tests_misc
Details
@flutter-dashboard
Mac framework_tests_widgets
Details
@flutter-dashboard
Mac tool_tests_commands
Details
@wip
WIP Ready for review
Details
@flutter-dashboard
Windows build_tests_1_3
Details
@flutter-dashboard
Windows build_tests_2_3
Details
@flutter-dashboard
Windows build_tests_3_3
Details
@flutter-dashboard
Windows customer_testing
Details
@flutter-dashboard
Windows framework_tests_libraries
Details
@flutter-dashboard
Windows framework_tests_misc
Details
@flutter-dashboard
Windows framework_tests_widgets
Details
@cirrus-ci
analyze-linux Task Summary
Details
@flutter-dashboard
ci.yaml validation .ci.yaml validation
Details
@google-cla
cla/google All necessary CLAs are signed
@cirrus-ci
customer_testing-linux Task Summary
Details
@cirrus-ci
docs-linux Task Summary
Details
@flutter-dashboard
flutter-gold All golden file tests have passed.
Details
@cirrus-ci
framework_tests-libraries-linux Task Summary
Details
@cirrus-ci
framework_tests-misc-linux Task Summary
Details
@cirrus-ci
framework_tests-widgets-linux Task Summary
Details
@flutter-dashboard
luci-flutter
Details
@cirrus-ci
web_smoke_test Task Summary
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

4 participants