Formed in 2009, the Archive Team (not to be confused with the archive.org Archive-It Team) is a rogue archivist collective dedicated to saving copies of rapidly dying or deleted websites for the sake of history and digital heritage. The group is 100% composed of volunteers and interested parties, and has expanded into a large amount of related projects for saving online and digital history.
Add raster cache metrics to timeline summaries #89393
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat. If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
|
The comment about the lack of testing is now obsolete as there are existing tests that I had to modify to get this to pass, so the additions are now tested for. |
flar
force-pushed the
flar:add-raster-cache-metrics-to-timeline-summaries
branch
from
3976d77
to
f97664b
|
The FrameTiming mods have rolled in from the engine repo and the latest commit now publishes those metrics as well for e2e benchmarks. |
fluttergithubbot
merged commit abfb889
into
flutter:master
Recently some internal benchmarks have pointed out higher memory usage while using the DisplayList mechanism. In diagnosing the issue locally we realized we are using a lot more cache memory for internal benchmarks like the flutter_gallery. This PR will add statistics for layer and raster cache usage to the standard benchmark measurements we take for flutter_gallery which should alert us to issues in the future.