The Wayback Machine - https://web.archive.org/web/20210906115034/https://github.com/RustPython/RustPython/issues/2839
Skip to content

/ RustPython

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

collections.deque doesn't have __imul__ method. #2839

Open
Tracked in #2812
DimitrisJim opened this issue Aug 10, 2021 · 7 comments · May be fixed by #3020
Open
Tracked in #2812

collections.deque doesn't have __imul__ method. #2839

DimitrisJim opened this issue Aug 10, 2021 · 7 comments · May be fixed by #3020
Assignees
@ConnorTroy
Labels
good first issue

Comments

@DimitrisJim
Copy link
Member

@DimitrisJim DimitrisJim commented Aug 10, 2021 •
edited

Feature

CPython:

>>> from collections import deque
>>> d = deque()
>>> d.__imul__(3)
deque([1, 1, 1, 1, 1])

RustPython:

>>>>> from collections import deque
>>>>> d = deque()
>>>>> d.__imul__(5)
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
AttributeError: 'deque' object has no attribute '__imul__'
@DimitrisJim DimitrisJim mentioned this issue Aug 10, 2021
Open
6 tasks
@architjen
Copy link

@architjen architjen commented Aug 11, 2021

Hi @DimitrisJim, I'm new to open-source, can I take up this issue?

@DimitrisJim
Copy link
Member Author

@DimitrisJim DimitrisJim commented Aug 11, 2021

@architjen sure! Go for it.

@ConnorTroy
Copy link

@ConnorTroy ConnorTroy commented Sep 4, 2021

@architjen Are you still working this? If not, @DimitrisJim can I take over?

@youknowone youknowone assigned ConnorTroy and unassigned architjen Sep 4, 2021
@DimitrisJim
Copy link
Member Author

@DimitrisJim DimitrisJim commented Sep 4, 2021

I last talked with Archit three days or so ago. Maybe give them a day to respond before submitting something just in case.

@youknowone
Copy link
Member

@youknowone youknowone commented Sep 4, 2021 •
edited

Ah, got it. I didn't know that.

For everyone: we don't have strict rule for assignment of issues. we do that just for easier communication, not to make duplicated effort for same issues. Please note that assignment doesn't mean any responsibility, permission or exclusive right is granted to the assignees.

@DimitrisJim
Copy link
Member Author

@DimitrisJim DimitrisJim commented Sep 4, 2021 •
edited

No prob, I'll try and get a hold of them on gitter today and ask if they can follow through with it.

@architjen
Copy link

@architjen architjen commented Sep 4, 2021

Hii @ConnorTroy, sure you can take over the issue!

@ConnorTroy ConnorTroy linked a pull request that will close this issue Sep 6, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ConnorTroy ConnorTroy

Labels
good first issue
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

Add deque __imul__ method
4 participants
@youknowone @DimitrisJim @architjen @ConnorTroy