The Wayback Machine - https://web.archive.org/web/20210906134733/https://github.com/TheAlgorithms/C-Plus-Plus/pull/1584
Skip to content

/ C-Plus-Plus

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create c++_code_fixes #1584

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Create c++_code_fixes #1584

wants to merge 5 commits into from
+25 −1

Conversation

@Bhagyanekraje
Copy link

@Bhagyanekraje Bhagyanekraje commented Sep 4, 2021 •
edited by gitpod-io bot

In this file I have written a c++ code to find the reverse of a string without using functions.

Description of Change

Checklist

  • Added description of change
  • Added file name matches File name guidelines
  • Added tests and example, test must pass
  • Added documentation so that the program is self-explanatory and educational - Doxygen guidelines
  • Relevant documentation/comments is changed or added
  • PR title follows semantic commit guidelines
  • Search previous suggestions before making a new one, as yours may be a duplicate.
  • I acknowledge that all my contributions will be made under the project's license.

Notes:

@Bhagyanekraje
Create c++_code_fixes
e8790d1 
In this file I have written a c++ code to find the reverse of a string without using functions.
@Bhagyanekraje
Update linear_search.cpp
9941212 
Made minor changes in the documentation also changed the return type of main from int to void
@mishraabhinn
mishraabhinn requested changes Sep 4, 2021
View changes
Copy link
Member

@mishraabhinn mishraabhinn left a comment

Refer
@Bhagyanekraje
@mishraabhinn
mishraabhinn requested changes Sep 4, 2021
View changes
search/linear_search.cpp Outdated Show resolved Hide resolved
mishraabhinn and others added 3 commits Sep 4, 2021
@mishraabhinn
Merge branch 'master' into master
9838b36
@Bhagyanekraje
Update c++_code_fixes
21cb461 
changed the return type of main function from void to int
@Bhagyanekraje
Update linear_search.cpp
96cc513 
Sir I thought if the code is not further used for any other purpose then void is best to use.If the piece of code has to be used in any other programs in future then int is best.I have again changed it to int.Do check it.
@mishraabhinn
Copy link
Member

@mishraabhinn mishraabhinn commented Sep 5, 2021

@Bhagyanekraje Please do check the relevant checkbox, and please do refer to the contribution guidelines before commiting. For any question you can ask here or do message your doubts on Gitter Thanks.
Screenshot 2021-09-05 at 12 44 59

@Bhagyanekraje
Bhagyanekraje reviewed Sep 5, 2021
View changes
Copy link
Author

@Bhagyanekraje Bhagyanekraje left a comment

@Bhagyanekraje Please do check the relevant checkbox, and please do refer to the contribution guidelines before commiting. For any question you can ask here or do message your doubts on Gitter Thanks.
Screenshot 2021-09-05 at 12 44 59

ok sir
search/linear_search.cpp Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mishraabhinn mishraabhinn

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
automated tests are failing awaiting modification good first issue Proper Documentation Required
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
@Bhagyanekraje @mishraabhinn