The Wayback Machine - https://web.archive.org/web/20220408051410/https://github.com/status-im/status-react/issues/11528
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add custom clj-kondo hooks for custom macroses #11528

Open
Ferossgp opened this issue Dec 8, 2020 · 1 comment
Open

Add custom clj-kondo hooks for custom macroses #11528

Ferossgp opened this issue Dec 8, 2020 · 1 comment
Labels
bounty-xs developer-xp good first issue

Comments

@Ferossgp
Copy link
Contributor

@Ferossgp Ferossgp commented Dec 8, 2020 •
edited by StatusWrike

Add custom clj-kondo hooks for macroses to ensure that lint rules are followed inside them.

Macros to be handled:

  • fx/defn - similarly to defn with check on metadata for ::events
  • fx/merge - seems like it could be lint'ed as thread macro, plus warn on limitations
  • defview
  • letsubs - lint as let + check on types for the values, warn on chained subscription
@Ferossgp Ferossgp added developer-xp feature labels Dec 8, 2020
@Ferossgp
Copy link
Contributor Author

@Ferossgp Ferossgp commented Dec 11, 2020 •
edited

fx/defn are not tracked by carve thus we have a lot of dead code in the fx/defn. I assume that fixing clj-kondo lint will open the ability to carve them too, but would require to carve only definitions without {:events []}

@status-im status-im deleted a comment from mostafarahimifard Oct 21, 2021
@flexsurfer flexsurfer removed the feature label Jan 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bounty-xs developer-xp good first issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@cammellos @Ferossgp @flexsurfer