The Wayback Machine - https://web.archive.org/web/20220207043443/https://github.com/GitSquared/edex-ui/pull/573
Skip to content
This repository has been archived by the owner. It is now read-only.

♻️ convert file-icons to git submodules #573

Merged
merged 3 commits into from Aug 30, 2019

Conversation

@shinenelson
Copy link
Contributor

@shinenelson shinenelson commented Aug 29, 2019

It makes sense to maintain the file-icons as git submodules since it becomes easier to maintain and manage as it can be automatically done with git.

The current method of adding and updating file-icons ( with basic git clone and git pull commands ) looks kind of clumsy and hack-y.

@GitSquared
Copy link
Owner

@GitSquared GitSquared commented Aug 30, 2019

👍 Good call. I heard about git submodules before, but didn't take the time to learn how to use them. This is indeed way cleaner than a manual git clone script.

Thanks!

@GitSquared GitSquared merged commit 8327ac4 into GitSquared:master Aug 30, 2019
3 of 4 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants