The Wayback Machine - https://web.archive.org/web/20211117042712/https://github.com/adafruit/circuitpython/pull/5308
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert localization of REPL messages #5308

Merged
merged 1 commit into from Sep 8, 2021
Merged

Revert localization of REPL messages #5308

merged 1 commit into from Sep 8, 2021

Conversation

Reviewers

@tannewt tannewt

Assignees
No one assigned
Labels
bug crash
Projects
None yet
Milestone
7.0.0
Linked issues

Successfully merging this pull request may close these issues.

Raw REPL marker missing in CP 7.0 rc1
2 participants
@microDev1 @tannewt
@microDev1
Copy link
Collaborator

@microDev1 microDev1 commented Sep 7, 2021 •
edited
Loading

Closes #5307.
@microDev1 microDev1 changed the title Add pyexec to qstr sources and compress messages Revert localization of REPL messages Sep 7, 2021
@microDev1 microDev1 added this to the 7.0.0 milestone Sep 7, 2021
tannewt
tannewt requested changes Sep 7, 2021
View changes
Copy link
Member

@tannewt tannewt left a comment

Are there control characters that we could use instead of reverting this? I don't like prioritizing interfacing with a machine over a human. (Will follow up on the issue too. Thanks for the quick PR.)

Loading

tannewt
tannewt approved these changes Sep 8, 2021
View changes
@tannewt tannewt merged commit cfc4ed1 into adafruit:main Sep 8, 2021
237 checks passed
Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment