The Wayback Machine - https://web.archive.org/web/20211003223333/https://github.com/kubernetes/kubernetes/issues/104418
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add non-serialized metrics tests for Windows #104418

Open
jayunit100 opened this issue Aug 17, 2021 · 13 comments
Open

Add non-serialized metrics tests for Windows #104418

jayunit100 opened this issue Aug 17, 2021 · 13 comments

Comments

@jayunit100
Copy link
Member

@jayunit100 jayunit100 commented Aug 17, 2021

What happened:

  • Lets put a metrics CI job in place that isnt Serial.
  • Investigate our test coverage of metrics-server
  • See why our CI jobs dont test metrics-server
  • Confirm that we are doing enough in kubelet_stats

What you expected to happen:

https://github.com/kubernetes/kubernetes/blob/master/test/e2e/windows/kubelet_stats.go is a good test, lets make it part of all our containerd jobs by removing the Serial tags

@k8s-ci-robot
Copy link
Contributor

@k8s-ci-robot k8s-ci-robot commented Aug 17, 2021

@jayunit100: This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jayunit100
Copy link
Member Author

@jayunit100 jayunit100 commented Aug 17, 2021

/sig windows

@jayunit100
Copy link
Member Author

@jayunit100 jayunit100 commented Aug 17, 2021

/good-first-issue

@k8s-ci-robot
Copy link
Contributor

@k8s-ci-robot k8s-ci-robot commented Aug 17, 2021

@jayunit100:
This request has been marked as suitable for new contributors.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-good-first-issue command.

In response to this:

/good-first-issue

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@FriedrichWilken
Copy link

@FriedrichWilken FriedrichWilken commented Aug 17, 2021

/assign

@jayunit100
Copy link
Member Author

@jayunit100 jayunit100 commented Aug 17, 2021

while were at it

 				for i := 0; i < iterations; i++ {

make that iterations a non-magic number

@jayunit100
Copy link
Member Author

@jayunit100 jayunit100 commented Aug 17, 2021

while were at it make sure the metrics stats are non-zero , so that we catch regressions #104287

  • turns out we DO run SERIAL jobs in the sig-windows dashboard
  • either we dont collect enough metrics, so the tests pass, or we do, and we dont watch the dashboards :)
  • https://k8s-testgrid.appspot.com/ <-- check the sig-windows dashboard...

@marosset
Copy link
Contributor

@marosset marosset commented Aug 26, 2021

@jayunit100 this test starts 10 pods on a node at once and run into issues starting 10 pods on a single node when this was run in parallel with other jobs.

Maybe we should consider adding a different metrics job that just starts 1-3 pods and does deeper validation of the metrics retruned?

@marosset marosset added this to Backlog (v 1.23) in SIG-Windows Aug 26, 2021
@san-coding
Copy link

@san-coding san-coding commented Sep 14, 2021

Hey, is this issue still open? I would like to work on this, I am new to open source

@marosset
Copy link
Contributor

@marosset marosset commented Sep 14, 2021

@san-coding
We cannot de-serialize the existing metrics job due to its nature.
We can however create new test cases that do not need to be run in parallel and do deeper validation of metrics like Jay suggested above.
I'm not sure if @FriedrichWilken is still working on the issue. If not feel free to work on this.

Thanks!

@FriedrichWilken
Copy link

@FriedrichWilken FriedrichWilken commented Sep 14, 2021

/unassign

@marosset
Copy link
Contributor

@marosset marosset commented Sep 14, 2021

/retitle Add non-serialized metrics tests for Windows

@k8s-ci-robot k8s-ci-robot changed the title De-serialize the metrics-ci jobs for windows Add non-serialized metrics tests for Windows Sep 14, 2021
@NikhilSharmaWe
Copy link

@NikhilSharmaWe NikhilSharmaWe commented Sep 20, 2021

I would like to contribute to solve this issue. Can someone help me to get a clear picture what are trying to do and how can I proceed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
SIG-Windows
  
Backlog (v 1.23)
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
6 participants