The Wayback Machine - https://web.archive.org/web/20210910033909/https://github.com/python/cpython/pull/28246
Skip to content

/ cpython Public

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-45017: move opcode-related logic from modulefinder to dis #28246

Merged
merged 5 commits into from Sep 9, 2021
Merged

bpo-45017: move opcode-related logic from modulefinder to dis #28246

merged 5 commits into from Sep 9, 2021

Conversation

@iritkatriel
Copy link
Member

@iritkatriel iritkatriel commented Sep 8, 2021 •
edited by bedevere-bot

https://bugs.python.org/issue45017
@iritkatriel
bpo-45017: move opcode-related logic from modulefinder to dis
c065b07
@blurb-it
📜🤖 Added by blurb_it.
946adb9
@iritkatriel iritkatriel requested review from 1st1, markshannon and gvanrossum Sep 8, 2021
@1st1
1st1 reviewed Sep 8, 2021
View changes
Lib/dis.py Outdated Show resolved Hide resolved
@1st1
1st1 reviewed Sep 8, 2021
View changes
Lib/test/test_dis.py Outdated Show resolved Hide resolved
@1st1
1st1 approved these changes Sep 8, 2021
View changes
Copy link
Member

@1st1 1st1 left a comment

I'm not the code owner here but the refactoring looks ok to me.
iritkatriel added 3 commits Sep 8, 2021
@iritkatriel
tuple to set
62afef8
@iritkatriel
added test for star imports
151c27a
@iritkatriel
make the two new dis functions private
117f7d5
@iritkatriel iritkatriel requested a review from isidentical Sep 9, 2021
@iritkatriel iritkatriel merged commit 04676b6 into python:main Sep 9, 2021
11 checks passed
11 checks passed
@github-actions
Check for source changes
Details
@github-actions
Check if generated files are up to date
Details
@github-actions
Windows (x86)
Details
@github-actions
Windows (x64)
Details
@github-actions
macOS
Details
@github-actions
Ubuntu
Details
@github-actions
Ubuntu SSL tests with OpenSSL
Details
@github-actions
Address sanitizer Address sanitizer
Details
Azure Pipelines PR #20210909.14 succeeded
Details
@bedevere-bot
bedevere/issue-number Issue number 45017 found
Details
@bedevere-bot
bedevere/news "skip news" label found
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@1st1 1st1

@markshannon markshannon

@gvanrossum gvanrossum

@isidentical isidentical

Assignees
No one assigned
Labels
CLA signed skip news
Projects
None yet
Milestone
No milestone
4 participants
@iritkatriel @1st1 @the-knights-who-say-ni @bedevere-bot