The Wayback Machine - https://web.archive.org/web/20210726141307/https://github.com/python/cpython/pull/27210
Skip to content

/ cpython

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-44659: Replace @ilevkivskyi with @Fidget-Spinner as typing code owner #27210

Merged
merged 1 commit into from Jul 17, 2021
Merged

bpo-44659: Replace @ilevkivskyi with @Fidget-Spinner as typing code owner #27210

merged 1 commit into from Jul 17, 2021
+1 −1

Conversation

@ambv
Copy link
Contributor

@ambv ambv commented Jul 17, 2021 •
edited by bedevere-bot

https://bugs.python.org/issue44659
@ambv
Replace @ilevkivskyi with @Fidget-Spinner as typing code owner
83c46c5
@Fidget-Spinner
Fidget-Spinner approved these changes Jul 17, 2021
View changes
Copy link
Contributor

@Fidget-Spinner Fidget-Spinner left a comment •
edited

LGTM. Though it feels weird seeing my handle there ;). We need to backport this to 3.10 and 3.9 too right? Otherwise backport PRs will ping Ivan.
@ambv
Copy link
Contributor Author

@ambv ambv commented Jul 17, 2021

Yes, this will indeed need backports.
@ambv
Copy link
Contributor Author

@ambv ambv commented Jul 17, 2021

Sorry, Ivan, address sanitizer refuses to let you go.
@ambv ambv merged commit 311ee83 into python:main Jul 17, 2021
12 of 13 checks passed
12 of 13 checks passed
@github-actions
Check for source changes
Details
@github-actions
Check if generated files are up to date
Details
@github-actions
Windows (x86)
Details
@github-actions
Windows (x64) Windows (x64)
Details
@github-actions
macOS
Details
@github-actions
Ubuntu
Details
@github-actions
Ubuntu SSL tests with OpenSSL (1.1.1k)
Details
@github-actions
Ubuntu SSL tests with OpenSSL (3.0.0-beta1)
Details
@github-actions
Address sanitizer Address sanitizer
Details
Azure Pipelines PR #20210717.16 succeeded
Details
@travis-ci
Travis CI - Pull Request Build Passed
Details
@bedevere-bot
bedevere/issue-number Issue number 44659 found
Details
@bedevere-bot
bedevere/news "skip news" label found
@bedevere-bot
Copy link

@bedevere-bot bedevere-bot commented Jul 17, 2021

@ambv: Please replace # with GH- in the commit message next time. Thanks!
@miss-islington
Copy link
Contributor

@miss-islington miss-islington commented Jul 17, 2021

Thanks @ambv for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.9.
🐍🍒⛏🤖
@ambv ambv deleted the ambv:remove-ivan branch Jul 17, 2021
@bedevere-bot
Copy link

@bedevere-bot bedevere-bot commented Jul 17, 2021

GH-27212 is a backport of this pull request to the 3.10 branch.
miss-islington added a commit to miss-islington/cpython that referenced this pull request Jul 17, 2021
@ambv @miss-islington
Replace @ilevkivskyi with @Fidget-Spinner as typing code owner (pytho…
a9acc07 
…nGH-27210)

(cherry picked from commit 311ee83)

Co-authored-by: Łukasz Langa <[email protected]>
@bedevere-bot
Copy link

@bedevere-bot bedevere-bot commented Jul 17, 2021

GH-27213 is a backport of this pull request to the 3.9 branch.
miss-islington added a commit to miss-islington/cpython that referenced this pull request Jul 17, 2021
@ambv @miss-islington
Replace @ilevkivskyi with @Fidget-Spinner as typing code owner (pytho…
d7e0957 
…nGH-27210)

(cherry picked from commit 311ee83)

Co-authored-by: Łukasz Langa <[email protected]>
@Fidget-Spinner
Copy link
Contributor

@Fidget-Spinner Fidget-Spinner commented Jul 17, 2021

Wow we managed to break ASAN 😉.

Thanks again for handling this Łukasz!
@ambv
Copy link
Contributor Author

@ambv ambv commented Jul 17, 2021

Naturally, it's literally my job.
@Fidget-Spinner
Copy link
Contributor

@Fidget-Spinner Fidget-Spinner commented Jul 17, 2021

Haha, congrats on the position :).
ambv added a commit that referenced this pull request Jul 17, 2021
@miss-islington @ambv
Replace @ilevkivskyi with @Fidget-Spinner as typing code owner (GH-27210
8187033 
) (#27213)

(cherry picked from commit 311ee83)

Co-authored-by: Łukasz Langa <[email protected]>
ambv added a commit that referenced this pull request Jul 17, 2021
@miss-islington @ambv
Replace @ilevkivskyi with @Fidget-Spinner as typing code owner (GH-27210
e22e864 
) (#27212)

(cherry picked from commit 311ee83)

Co-authored-by: Łukasz Langa <[email protected]>
@isidentical
Copy link
Member

@isidentical isidentical commented Jul 17, 2021 •
edited

Ah, I think this might not work for triagers :/

The people you choose as code owners must have write permissions for the repository.

https://docs.github.com/en/github/creating-cloning-and-archiving-repositories/creating-a-repository-on-github/about-code-owners
@ambv
Copy link
Contributor Author

@ambv ambv commented Jul 17, 2021

There's a few ways we can fix this 😎
@pablogsal pablogsal mentioned this pull request Jul 18, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Fidget-Spinner Fidget-Spinner

Assignees
No one assigned
Labels
CLA signed skip news
Projects
None yet
Milestone
No milestone
6 participants
@ambv @bedevere-bot @miss-islington @Fidget-Spinner @isidentical @the-knights-who-say-ni