The Wayback Machine - https://web.archive.org/web/20210904012125/https://github.com/NativeScript/NativeScript/pull/9528
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix:(README.md)some grammatical misktakes and simplified it #9528

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

@Adarshjaiss
Copy link

@Adarshjaiss Adarshjaiss commented Aug 31, 2021

I have done some minor grammatical changes in readme file, and simplified some sentences which was creating a little bit problem from the contributors to understand.

PR Checklist

What is the current behavior?

What is the new behavior?

Fixes/Implements/Closes #[Issue Number].

I have done some minor grammatical changes in readme file, and simplified some sentences which was creating a little bit problem from the contributors to understand.
@cla-bot
Copy link

@cla-bot cla-bot bot commented Aug 31, 2021

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign the CLA at https://www.nativescript.org/cla.
CLA has not been signed by users: @Adarshjaiss.
After signing the CLA, you can ask me to recheck this PR by posting @cla-bot check as a comment to the PR.

@Adarshjaiss
Copy link
Author

@Adarshjaiss Adarshjaiss commented Aug 31, 2021

@cla-bot check

@cla-bot cla-bot bot added the cla: yes label Aug 31, 2021
@cla-bot
Copy link

@cla-bot cla-bot bot commented Aug 31, 2021

The cla-bot has been summoned, and re-checked this pull request!

@Adarshjaiss Adarshjaiss changed the title Updated README. md fix: Updated README. md Aug 31, 2021
@Adarshjaiss Adarshjaiss changed the title fix: Updated README. md fix:( README. md) Aug 31, 2021
@Adarshjaiss Adarshjaiss changed the title fix:( README. md) fix:README. md: updated some grammatical misktakes Aug 31, 2021
@Adarshjaiss Adarshjaiss changed the title fix:README. md: updated some grammatical misktakes Fix:(README.md)some grammatical misktakes and simplified it Aug 31, 2021
@@ -52,9 +52,9 @@ We love you and PR's 🤗 Please follow our [contributing guide](https://github.
- [NativeScript on Stack Overflow](http://stackoverflow.com/questions/tagged/nativescript)
- [NativeScript documentation](https://docs.nativescript.org/)

## Other framework source repositories
## our Other frameworks sources repositories:-

This comment has been minimized.

@NathanWalker

NathanWalker Sep 2, 2021
Contributor

Thank you @Adarshjaiss for these improvements. Everything looks great, although this one sounds a bit funny, how about just:

## More source repos

If you don't mind making that one adjustment we'd love to get this merged.

This comment has been minimized.

@Adarshjaiss

Adarshjaiss Sep 3, 2021
Author

@nathan Walker Thank you sir, for mentoring and reviewing this code. Actually, I have done that silly mistake, I am sorry for that. I am just correcting it. 🙂

This comment has been minimized.

@NathanWalker

NathanWalker Sep 3, 2021
Contributor

You’ll notice in the changeset above in green, no further change has been pushed yet. Perhaps you made the change locally but haven’t committed and pushed it yet?

@Adarshjaiss Adarshjaiss requested a review from NathanWalker Sep 3, 2021
@@ -52,9 +52,9 @@ We love you and PR's 🤗 Please follow our [contributing guide](https://github.
- [NativeScript on Stack Overflow](http://stackoverflow.com/questions/tagged/nativescript)
- [NativeScript documentation](https://docs.nativescript.org/)

## Other framework source repositories
## our Other frameworks sources repositories:-

This comment has been minimized.

@NathanWalker

NathanWalker Sep 3, 2021
Contributor

You’ll notice in the changeset above in green, no further change has been pushed yet. Perhaps you made the change locally but haven’t committed and pushed it yet?

@Adarshjaiss Adarshjaiss marked this pull request as draft Sep 3, 2021
@Adarshjaiss Adarshjaiss marked this pull request as ready for review Sep 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants