Fix:(README.md)some grammatical misktakes and simplified it #9528
Conversation
I have done some minor grammatical changes in readme file, and simplified some sentences which was creating a little bit problem from the contributors to understand.
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign the CLA at https://www.nativescript.org/cla. |
@cla-bot check |
The cla-bot has been summoned, and re-checked this pull request! |
@@ -52,9 +52,9 @@ We love you and PR's 🤗 Please follow our [contributing guide](https://github. | |||
- [NativeScript on Stack Overflow](http://stackoverflow.com/questions/tagged/nativescript) | |||
- [NativeScript documentation](https://docs.nativescript.org/) | |||
|
|||
## Other framework source repositories | |||
## our Other frameworks sources repositories:- |
NathanWalker
Sep 2, 2021
Contributor
Thank you @Adarshjaiss for these improvements. Everything looks great, although this one sounds a bit funny, how about just:
## More source repos
If you don't mind making that one adjustment we'd love to get this merged.
Thank you @Adarshjaiss for these improvements. Everything looks great, although this one sounds a bit funny, how about just:
## More source repos
If you don't mind making that one adjustment we'd love to get this merged.
Adarshjaiss
Sep 3, 2021
Author
@nathan Walker Thank you sir, for mentoring and reviewing this code. Actually, I have done that silly mistake, I am sorry for that. I am just correcting it. 🙂
@nathan Walker Thank you sir, for mentoring and reviewing this code. Actually, I have done that silly mistake, I am sorry for that. I am just correcting it.
NathanWalker
Sep 3, 2021
Contributor
You’ll notice in the changeset above in green, no further change has been pushed yet. Perhaps you made the change locally but haven’t committed and pushed it yet?
You’ll notice in the changeset above in green, no further change has been pushed yet. Perhaps you made the change locally but haven’t committed and pushed it yet?
@@ -52,9 +52,9 @@ We love you and PR's 🤗 Please follow our [contributing guide](https://github. | |||
- [NativeScript on Stack Overflow](http://stackoverflow.com/questions/tagged/nativescript) | |||
- [NativeScript documentation](https://docs.nativescript.org/) | |||
|
|||
## Other framework source repositories | |||
## our Other frameworks sources repositories:- |
NathanWalker
Sep 3, 2021
Contributor
You’ll notice in the changeset above in green, no further change has been pushed yet. Perhaps you made the change locally but haven’t committed and pushed it yet?
You’ll notice in the changeset above in green, no further change has been pushed yet. Perhaps you made the change locally but haven’t committed and pushed it yet?
I have done some minor grammatical changes in readme file, and simplified some sentences which was creating a little bit problem from the contributors to understand.
PR Checklist
What is the current behavior?
What is the new behavior?
Fixes/Implements/Closes #[Issue Number].