The Wayback Machine - https://web.archive.org/web/20211004072916/https://github.com/matplotlib/matplotlib/pull/21051
Skip to content

/ matplotlib Public

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

set_dashes does not support offset=None anymore. #21051

Merged
merged 1 commit into from Sep 13, 2021
Merged

set_dashes does not support offset=None anymore. #21051

merged 1 commit into from Sep 13, 2021
+3 −25

Conversation

@anntzer
Copy link
Contributor

@anntzer anntzer commented Sep 11, 2021

This was deprecated in 3.3 (eb76378) and removed in most places in
c51ae6d; this patch removes supports on the C side and mentions of it
in docs.

Also remove the dashobj == NULL && dashobj == Py_None check, which can
never be true.

PR Summary

PR Checklist

  • Has pytest style unit tests (and pytest passes).
  • Is Flake 8 compliant (run flake8 on changed files to check).
  • New features are documented, with examples if plot related.
  • Documentation is sphinx and numpydoc compliant (the docs should build without error).
  • Conforms to Matplotlib style conventions (install flake8-docstrings and run flake8 --docstring-convention=all).
  • New features have an entry in doc/users/next_whats_new/ (follow instructions in README.rst there).
  • API changes documented in doc/api/next_api_changes/ (follow instructions in README.rst there).
@anntzer
set_dashes does not support offset=None anymore.
f012a0d 
This was deprecated in 3.3 (eb76378) and removed in most places in
c51ae6d; this patch removes supports on the C side and mentions of it
in docs.

Also remove the `dashobj == NULL && dashobj == Py_None` check, which can
never be true.
@timhoffm timhoffm added this to the v3.5.0 milestone Sep 12, 2021
@QuLogic QuLogic merged commit 1a0ebbb into matplotlib:master Sep 13, 2021
28 checks passed
meeseeksmachine added a commit to meeseeksmachine/matplotlib that referenced this issue Sep 13, 2021
@QuLogic @meeseeksmachine
Backport PR matplotlib#21051: set_dashes does not support offset=None…
9b40f61 
… anymore.
@meeseeksmachine meeseeksmachine mentioned this pull request Sep 13, 2021
Merged
@anntzer anntzer deleted the gdbdashes branch Sep 14, 2021
QuLogic added a commit that referenced this issue Sep 14, 2021
@QuLogic
Merge pull request #21069 from meeseeksmachine/auto-backport-of-pr-21…
3dd25ed 
…051-on-v3.5.x

Backport PR #21051 on branch v3.5.x (set_dashes does not support offset=None anymore.)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@QuLogic QuLogic

@timhoffm timhoffm

Assignees
No one assigned
Labels
Maintenance
Projects
None yet
Milestone
v3.5.0
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
@anntzer @QuLogic @timhoffm