The Wayback Machine - https://web.archive.org/web/20210830233707/https://github.com/splitbrain/dokuwiki/issues/3455
Skip to content

/ dokuwiki

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Notice with outside authentication and PHP8 #3455

Open
perrick opened this issue Apr 1, 2021 · 1 comment
Open

Notice with outside authentication and PHP8 #3455

perrick opened this issue Apr 1, 2021 · 1 comment
Labels
good first issue PHP 8
Projects
Release "Igor"

Comments

@perrick
Copy link

@perrick perrick commented Apr 1, 2021

We get a notice with our Dokuwiki install with PHP8 :

Warning: Trying to access array offset on value of type null in /dokuwiki/inc/common.php on line 169

Adding a verification with an "isset" shoud do the trick, i.e on line 169 :

if(!isset($info['userinfo']['name']) or !$info['userinfo']['name']) {
@phy25 phy25 added the PHP 8 label Apr 9, 2021
@Ammarpad
Copy link
Contributor

@Ammarpad Ammarpad commented Apr 25, 2021

This is not a PHP 8 issue. If $info['userinfo'] is null, array offset warning will be raised as far back as PHP 7.4. Guarding it with isset() seems prudent here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue PHP 8
Projects
Release "Igor"
Awaiting triage
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants
@splitbrain @phy25 @perrick @Ammarpad