The Wayback Machine - https://web.archive.org/web/20201004210747/https://github.com/sitespeedio/sitespeed.io/issues/2775
Skip to content

/ sitespeed.io

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

grafana link points to last page #2775

Open
matti opened this issue Nov 10, 2019 · 4 comments
Open

grafana link points to last page #2775

matti opened this issue Nov 10, 2019 · 4 comments
Labels
bug good first issue

Comments

@matti
Copy link

@matti matti commented Nov 10, 2019 

--multi
http://www.example.com/first
http://www.example.com/second

--> grafana link points to /second, but it would make more sense if it opened /first - now I need to manually click "Pages" and then select the first one.
@soulgalore soulgalore added the bug label Nov 10, 2019
@soulgalore
Copy link
Member

@soulgalore soulgalore commented Nov 10, 2019

This looks like a bug, there should be one annotation per URL.
@soulgalore soulgalore removed the bug label Nov 12, 2019
@soulgalore
Copy link
Member

@soulgalore soulgalore commented Nov 12, 2019

Can you show me more how it doesn't work for you? I tried with: --graphite.host 127.0.0.1 https://www.sitespeed.io https://www.sitespeed.io/documentation/ --multi -n 1 --headless --resultBaseURL https://result.sitespeed.io/ and looking at the annotation there are one per URL and they point to each start test page for that URL?

I'm using Graphite, the default annotations. Check the tags, there should be a tag for the path of the URL.

Screenshot 2019-11-12 at 20 55 24

Screenshot 2019-11-12 at 20 55 13
@matti
Copy link
Author

@matti matti commented Nov 27, 2019

so when I run

--multi 
https://icebreaker.vc/
https://icebreaker.vc/

and when I click the result link in grafana annotation, then it throws me to:

image

so I'm on the second run (browsertime_run=2) and I need to click "Pages" so that I can get to the first run:

image
@soulgalore
Copy link
Member

@soulgalore soulgalore commented Nov 27, 2019

That was not the example you showed in the issue :) Yes looks that that could be fixed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug good first issue
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
@matti @soulgalore
You can’t perform that action at this time.