The Wayback Machine - https://web.archive.org/web/20210919150128/https://github.com/quasarframework/quasar/issues/8619
Skip to content

/ quasar Public

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

QInnerLoading - Add label #8619

Open
DocBouCou opened this issue Mar 13, 2021 · 4 comments
Open

QInnerLoading - Add label #8619

DocBouCou opened this issue Mar 13, 2021 · 4 comments
Labels
Good first issue 📄 docs Qv1

Comments

@DocBouCou
Copy link
Contributor

@DocBouCou DocBouCou commented Mar 13, 2021

Is your feature request related to a problem? Please describe.
I am using QInnerLoading a lot in my app, I think it is very convenient. I have a very common use case which is not directly covered by the component: I put a short explanation text under the spinner (e.g. "checking parameters...", "saving..." etc.).

Describe the solution you'd like
A direct solution would be to add optional "label" and "text-color" props. If not empty, it shows the text.

Describe alternatives you've considered
I am using the default slot to add default spinner and a short text. It works, it is easy, but not really convenient.
@DocBouCou DocBouCou changed the title QInnerLoading QInnerLoading - Add label Mar 13, 2021
@metalsadman
Copy link
Member

@metalsadman metalsadman commented Mar 14, 2021

you could make a wrapper of what you're currently doing and implement those custom props you mentioned.

@DocBouCou
Copy link
Contributor Author

@DocBouCou DocBouCou commented Mar 14, 2021

you could make a wrapper of what you're currently doing and implement those custom props you mentioned.

This is indeed what I did. As I thought it might be a common need, I proposed it as a feature. Or, if not so common, we might add an example of such wrapper in the docs, what do you think?

@metalsadman
Copy link
Member

@metalsadman metalsadman commented Mar 15, 2021

you could make a wrapper of what you're currently doing and implement those custom props you mentioned.

This is indeed what I did. As I thought it might be a common need, I proposed it as a feature. Or, if not so common, we might add an example of such wrapper in the docs, what do you think?

good idea, PR would be nice.

mortezasabihi added a commit to mortezasabihi/quasar that referenced this issue Apr 22, 2021
@mortezasabihi
feat(docs): QInnerLoading example with label added (feat quasarframew…
d429f53 
…ork#8619)
@MilosPaunovic
Copy link
Contributor

@MilosPaunovic MilosPaunovic commented May 26, 2021

@DocBouCou I've added the label and label-color props to the QInnerLoading component and made a PR for it #9433.

If label is used (disregarded when using default slot) it will add a span below the default spinner. And the label-color prop will set the color of that label to passed value (default is black).

Hopefully, someone form the Quasar core team will get a chance to look at it an merge soon :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Good first issue 📄 docs Qv1
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants
@pdanpdan @metalsadman @DocBouCou @MilosPaunovic