The Wayback Machine - https://web.archive.org/web/20210707034819/https://github.com/vercel/hyper/issues/2584
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

To support a single cross-platform settings file some of the settings should be platform specific (like in VS Code) #2584

Open
2 tasks done
brennanfee opened this issue Jan 10, 2018 · 0 comments

Comments

@brennanfee
Copy link
Task lists! Give feedback

@brennanfee brennanfee commented Jan 10, 2018

  • I am on the latest Hyper.app version

  • I have searched the issues of this repo and believe that this is not a duplicate

  • OS version and name: Windows 10 1709, Ubuntu 16.04, Ubuntu 17.10, macOS Sierra

  • Hyper.app version: 1.4.8

Feature Request

At present, with only a single "shell", "shellArgs", and "env" options I must maintain three different configs for the different OS platforms (where the only difference is in these three settings). This requires me to synchronize the rest of the settings manually in order to have the same experience across platforms. This kind of defeats the purpose of a cross-platform tool such as this.

VS Code gets around this problem by providing settings that are platform specific and the tool figures out which setting to use based on which platform it is running on. This is how I can have a single setting for VsCode that is shared across all machines.

In VS Code the relevant settings section looks like this:

"terminal.integrated.env.linux": {},
"terminal.integrated.env.osx": {},
"terminal.integrated.env.windows": {},

"terminal.integrated.shell.linux": "sh",
"terminal.integrated.shell.osx": "sh",
"terminal.integrated.shell.windows": "C:\WINDOWS\System32\WindowsPowerShell\v1.0\powershell.exe",

"terminal.integrated.shellArgs.linux": [],
"terminal.integrated.shellArgs.osx": [
"-l"
],
"terminal.integrated.shellArgs.windows": [],

Perhaps we could use:

shell.linux
shellArgs.linux
env.linux
shell.windows

and so on.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

2 participants