The Wayback Machine - https://web.archive.org/web/20210917221952/https://github.com/MoralCode/ClassClock/issues/20
Skip to content

/ ClassClock Public

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

App is not currently fully AGPL compliant #20

Open
MoralCode opened this issue Dec 4, 2019 · 2 comments
Open

App is not currently fully AGPL compliant #20

MoralCode opened this issue Dec 4, 2019 · 2 comments
Labels
good first issue help wanted
Projects
Roadmap

Comments

@MoralCode
Copy link
Owner

@MoralCode MoralCode commented Dec 4, 2019

In order to be AGPL compliant, the web app should link to this github repository somewhere on the site (probably at the bottom of the settings page somewhere) and include the hash of the commit that it was built from (adding the version number from package.json would also be nice).

This would probably work best for once the app has been Dockerized.

More info:
https://stackoverflow.com/questions/48391897/add-git-information-to-create-react-app
@MoralCode MoralCode added this to "Now" features in Roadmap Dec 4, 2019
@MoralCode MoralCode moved this from "Now" features to "Next" Features in Roadmap Dec 4, 2019
@MoralCode MoralCode moved this from "Next" Features to "Now" features in Roadmap Feb 17, 2020
@MoralCode MoralCode moved this from "Now" features to "Next" Features in Roadmap Apr 8, 2020
@MoralCode
Copy link
Owner Author

@MoralCode MoralCode commented May 12, 2020

this would be best achieved when ClassClock is migrated over to using docker so that this can be built right into the image.

see https://github.com/omarroth/invidious/blob/454ae8656a61188082e54e75c637e99425e0e2ac/src/invidious.cr#L62
https://github.com/omarroth/invidious/search?q=CURRENT_COMMIT&unscoped_q=CURRENT_COMMIT

@MoralCode
Copy link
Owner Author

@MoralCode MoralCode commented Jul 9, 2020

Alternatively, this can be built into the github-pages version of the site using this: https://stackoverflow.com/a/62767490

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue help wanted
Projects
Roadmap
  
"Next" Features
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant
@MoralCode