The Wayback Machine - https://web.archive.org/web/20211003223744/https://github.com/grafana/grafana/issues/32322
Skip to content

/ grafana Public

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AzureMonitor: Refactor data links and move to backend #32322

Open
1 of 2 tasks
joshhunt opened this issue Mar 25, 2021 · 1 comment
Open
1 of 2 tasks

AzureMonitor: Refactor data links and move to backend #32322

joshhunt opened this issue Mar 25, 2021 · 1 comment
Labels
datasource/Azure good first issue type/chore
Projects
Cloud Datasources - Kanban
Milestone
8.2.0

Comments

@joshhunt
Copy link
Contributor

@joshhunt joshhunt commented Mar 25, 2021 •
edited by iwysiu

In the Azure Monitor data source plugin, for Metrics and Logs queries, data links are added to the dataframes on the frontend (see processResponse), which is suboptimal. We should move these into the data source backend, like Azure Resource Graph.

This should happen for both Metrics and Logs queries, but as mentioned in #36242 (comment), we may need to change the URL format for Logs.

  • Metrics
  • Logs - link construction is async to fetch additional details, which may change once resource-centric queries are introduced
@joshhunt joshhunt added this to To do in Cloud Datasources - Kanban via automation Mar 25, 2021
@joshhunt joshhunt moved this from To do to Azure Backlog in Cloud Datasources - Kanban May 4, 2021
@vickyyyyyyy vickyyyyyyy moved this from Planned to Backlog in Cloud Datasources - Kanban Jul 2, 2021
@vickyyyyyyy vickyyyyyyy added this to the 8.2.0 milestone Jul 9, 2021
@joshhunt joshhunt moved this from Backlog to Sprint in Cloud Datasources - Kanban Aug 20, 2021
@sarahzinger sarahzinger moved this from Sprint to Backlog in Cloud Datasources - Kanban Aug 20, 2021
@andresmgot andresmgot removed this from the 8.2.0-beta1 milestone Sep 16, 2021
@andresmgot andresmgot added this to the 8.2.0 milestone Sep 16, 2021
@iwysiu iwysiu mentioned this issue Sep 22, 2021
Merged
@vickyyyyyyy vickyyyyyyy moved this from Backlog to In progress in Cloud Datasources - Kanban Sep 22, 2021
@iwysiu
Copy link
Contributor

@iwysiu iwysiu commented Sep 28, 2021

We're not moving the logs data links at this time, because the existing ones don't work and there's no sense in moving non-working code. They don't currently work because we don't have access to the way that log data links are constructed.

@iwysiu iwysiu moved this from In progress to Backlog in Cloud Datasources - Kanban Sep 29, 2021
@iwysiu iwysiu removed their assignment Sep 29, 2021
@ivanahuckova ivanahuckova removed this from the 8.2.0-beta2 milestone Sep 30, 2021
@ivanahuckova ivanahuckova added this to the 8.2.0 milestone Sep 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
datasource/Azure good first issue type/chore
Projects
Cloud Datasources - Kanban
Backlog
Milestone
8.2.0
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
5 participants
@joshhunt @andresmgot @iwysiu @ivanahuckova @vickyyyyyyy