The Wayback Machine - https://web.archive.org/web/20201017063111/https://github.com/hack4impact/flask-base/pull/50
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Code of Conduct #50

Merged
merged 3 commits into from Jul 26, 2016
Merged

Add Code of Conduct #50

merged 3 commits into from Jul 26, 2016

Conversation

@rileynwong
Copy link

@rileynwong rileynwong commented Jul 26, 2016

No description provided.

Nancy Wong
@abhisuri97
Copy link
Contributor

@abhisuri97 abhisuri97 commented Jul 26, 2016

lgtm. wait for a ok from an exec member and merge :)

@abhisuri97
Copy link
Contributor

@abhisuri97 abhisuri97 commented Jul 26, 2016

it might also be a good idea to include a small line in README.md referring to the conduct code.

@sandlerben
Copy link
Contributor

@sandlerben sandlerben commented Jul 26, 2016

ooh this is cool! lgtm

@abhisuri97
Copy link
Contributor

@abhisuri97 abhisuri97 commented Jul 26, 2016

@nancywong I added the reference to the code of conduct in README.md. Feel free to merge now.

Nancy Wong
@rileynwong rileynwong merged commit 6d0ddca into master Jul 26, 2016
1 check passed
1 check passed
ci/circleci Your tests passed on CircleCI!
Details
@rileynwong rileynwong deleted the code-of-conduct branch Jul 26, 2016
@rileynwong rileynwong changed the title Create CONDUCT.md Add Code of Conduct Jul 26, 2016
@yoninachmany
Copy link
Contributor

@yoninachmany yoninachmany commented Jul 31, 2016

@nancywong reason why CONDUCT.md exists here rather than https://github.com/hack4impact/constitution repo?

@abhisuri97
Copy link
Contributor

@abhisuri97 abhisuri97 commented Jul 31, 2016

@yoninachmany this was discussed in #meta but basically CONDUCT.md refers to the set of rules, guidelines, and values for open source contributions and our values regarding contributions in general. (common across several open source projects).

@yoninachmany
Copy link
Contributor

@yoninachmany yoninachmany commented Jul 31, 2016

@abhisuri97 thanks for fast and clear answer - i honestly didn't follow entire #meta conversation. maybe this was discussed, but since not all projects will be created from flask-base, how do we ensure that information from conduct.md will be known in that project?

@abhisuri97
Copy link
Contributor

@abhisuri97 abhisuri97 commented Jul 31, 2016

Well first note that any future flask-base projects and soon-to-be js-base projects that are forked from the respective bases will (by the nature of forking) include CONDUCT.md. If anyone would like to retroactively add CONDUCT.md to our previous projects, then feel free to do so.

But for future projects, I think it would be advisable to include this CONDUCT.md (or any similar) file to be explicit about the nature of open-source contributions towards our projects, whether they are derived from any "base" or not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.