The Wayback Machine - https://web.archive.org/web/20210918095653/https://github.com/cube-js/cube.js/pull/3430
Skip to content

/ cube.js Public

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(docs): transform content headers to links #3430

Merged
merged 4 commits into from Sep 17, 2021
Merged

chore(docs): transform content headers to links #3430

merged 4 commits into from Sep 17, 2021
+122 −34

Conversation

@YakovlevCoded
Copy link
Member

@YakovlevCoded YakovlevCoded commented Sep 15, 2021

Check List

  • Tests has been run in packages where changes made if available
  • Linter has been run for changed code
  • Tests for the changes have been added if not covered yet
  • Docs have been added / updated if required

Issue Reference this PR resolves

[For example #12]

Description of Changes Made (if issue reference is not provided)

[Description goes here]
@YakovlevCoded
use ScollLink to h2
b815922
@YakovlevCoded
try to add styles
6eea189
@YakovlevCoded
wrap to h2 tag
440feb4
@YakovlevCoded YakovlevCoded requested a review from as a code owner Sep 15, 2021
@YakovlevCoded YakovlevCoded requested review from igorlukanin and rchkv Sep 15, 2021
@YakovlevCoded
different headers for side menu and content
91b4131
igorlukanin
igorlukanin approved these changes Sep 17, 2021
View changes
Copy link
Member

@igorlukanin igorlukanin left a comment

@YakovlevCoded, LGTM but — I don't think this should be merged as fix(docs) (maybe chore(docs?) because it will then appear in the changelog.

@YakovlevCoded YakovlevCoded changed the title fix(docs): transform content headers to links chore(docs): transform content headers to links Sep 17, 2021
@YakovlevCoded YakovlevCoded merged commit 2f85136 into master Sep 17, 2021
3 checks passed
@YakovlevCoded YakovlevCoded deleted the leonid-yakovlev-headers-link branch Sep 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@igorlukanin igorlukanin

@rchkv rchkv

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
@YakovlevCoded @igorlukanin