The Wayback Machine - https://web.archive.org/web/20250521022449/https://github.com/github/opensource.guide/pull/2463
Skip to content

Fix editorial inconsistencies or inaccuracies #2463

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 5 commits into from
Closed

Fix editorial inconsistencies or inaccuracies #2463

wants to merge 5 commits into from

Conversation

Raphael-MOUQUIN
Copy link
Contributor

Improved translation

  • Have you followed the contributing guidelines?
  • Have you explained what your changes do, and why they add value to the Guides?

@Raphael-MOUQUIN Raphael-MOUQUIN requested a review from a team as a code owner July 7, 2021 16:39
@MaryJaneLove4

This comment has been minimized.

Sign in to view
@itsbagpack
Copy link
Contributor

Hi @Raphael-MOUQUIN, thank you for your contribution! It looks like there is a failing test associated with your PR. Could you take a look and fix it? We'll be able to re-review your PR after that. Thank you!

@Raphael-MOUQUIN
Copy link
Contributor Author

Raphael-MOUQUIN commented Aug 2, 2021 via email

@ApayRus
Copy link
Contributor

ApayRus commented Aug 19, 2021

Hi. On the page: https://opensource.guide/code-of-conduct/
the link "Ada Initiative" https://adainitiative.org/2014/02/18/howto-design-a-code-of-conduct-for-your-community/
is not working.
It causes failure of tests.

MikeMcQuaid
MikeMcQuaid suggested changes Sep 7, 2021
View reviewed changes
Copy link
Contributor

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the CI failures: https://github.com/github/opensource.guide/pull/2463/checks?check_run_id=3532339409#step:7:35

@MikeMcQuaid MikeMcQuaid closed this Oct 4, 2021
@Raphael-MOUQUIN
Copy link
Contributor Author

hi, there are still issues, why don't you merge?

Raphael-MOUQUIN
Raphael-MOUQUIN commented Nov 12, 2021
View reviewed changes
Copy link
Contributor Author

@Raphael-MOUQUIN Raphael-MOUQUIN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed and OK

@MikeMcQuaid
Copy link
Contributor

@Raphael-MOUQUIN I waited for a month for CI failures to be resolved.

@Raphael-MOUQUIN
Copy link
Contributor Author

@MikeMcQuaid oh! yes , it happens sometimes. Nevertheless you managed it then ?

@Raphael-MOUQUIN
Copy link
Contributor Author

So all the improvement job that has been done is lost ????

@MikeMcQuaid MikeMcQuaid reopened this Nov 12, 2021
@MikeMcQuaid
Copy link
Contributor

@Raphael-MOUQUIN I've reopened the PR. Please fix the CI status in the next week or we'll need to close this again, thanks.

@Raphael-MOUQUIN
Copy link
Contributor Author

@MikeMcQuaid Thanks! and sorry for your precious time. I just expected to help and now
we can see this replacement link is dead too. Google cache for that entry has been cleared.

@MikeMcQuaid
Copy link
Contributor

@Raphael-MOUQUIN this is the issue that needs fixed with your changes: https://github.com/github/opensource.guide/runs/4189065585?check_suite_focus=true#step:7:37

@Raphael-MOUQUIN
Copy link
Contributor Author

sorry, still don't get it. Cannot update my commit to validate it. Sorry, so much time/work lost due to a link on the page? An old link that hat nothing to do with the submitted improvements.? Anyway, I cannot manage to update that link that does NOT belong to the modified file I try to submit....

@Raphael-MOUQUIN
Copy link
Contributor Author

Still trying to understand the new way GitHub works ,
feeling like to give up but it's an opportunity to learn , yeah, i'll try later, already lost numerous minutes trying to fix the CI issue. Thanks anyway to all. Have a good day

@sas1354
Copy link

sas1354 commented Nov 12, 2021

@Raphael-MOUQUIN
Fixed link to internal page
f094018 
in the hope to fullfill tests to be able to merge github#2463
@MikeMcQuaid
Copy link
Contributor

Still failing I'm afraid @Raphael-MOUQUIN. You may want to run this in a local web server to figure out the name of the generated anchor.

@MikeMcQuaid
Copy link
Contributor

https://github.com/github/opensource.guide/runs/4189939137?check_suite_focus=true#step:7:37

Raphael-MOUQUIN added a commit to Raphael-MOUQUIN/opensource.guide that referenced this pull request Nov 13, 2021
@Raphael-MOUQUIN
Fixed broken link at line 172
f5c383a 
to solve github#2463
@Raphael-MOUQUIN Raphael-MOUQUIN mentioned this pull request Nov 13, 2021
Closed
Raphael-MOUQUIN added a commit to Raphael-MOUQUIN/opensource.guide that referenced this pull request Nov 13, 2021
@Raphael-MOUQUIN
Fixed 404 broken internal link
7c19cae 
to solve issue github#2463 (comment)
Hjordaan2002
Hjordaan2002 reviewed Nov 20, 2021
View reviewed changes
Copy link

@Hjordaan2002 Hjordaan2002 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good

@kenyonj
Copy link
Contributor

kenyonj commented Nov 26, 2021

Please feel free to open this back up when you can address the failing test. Thank you.

@kenyonj kenyonj closed this Nov 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hjordaan2002 Hjordaan2002 Hjordaan2002 left review comments

@MikeMcQuaid MikeMcQuaid MikeMcQuaid requested changes

@danielski1988 danielski1988 danielski1988 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@Raphael-MOUQUIN @MaryJaneLove4 @itsbagpack @ApayRus @MikeMcQuaid @sas1354 @kenyonj @danielski1988 @Hjordaan2002