The Wayback Machine - https://web.archive.org/web/20210921101012/https://github.com/cube-js/cube.js/pull/2377
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the Discourse link to the readme file #2377

Merged
merged 3 commits into from Mar 19, 2021
Merged

Conversation

@rpaik
Copy link
Member

@rpaik rpaik commented Mar 15, 2021

Check List

  • Tests has been run in packages where changes made if available
  • Linter has been run for changed code
  • Tests for the changes have been added if not covered yet
  • Docs have been added / updated if required

Issue Reference this PR resolves

[For example #12]

Description of Changes Made (if issue reference is not provided)

[Description goes here]

@rpaik rpaik requested a review from cube-js/developer-relations-and-community as a code owner Mar 15, 2021
@rpaik
Copy link
Member Author

@rpaik rpaik commented Mar 16, 2021

@keydunov @hassankhan @igorlukanin I think we may have too many links at the top of the readme file.

What do you think of removing links for Getting Started and/or Examples? Both are under docs and Getting Started is actually the first main tiles on the docs page

@hassankhan hassankhan added this to In progress in Roadmap 2021 Q1 via automation Mar 19, 2021
@hassankhan
Copy link
Member

@hassankhan hassankhan commented Mar 19, 2021

@rpaik I think this might be better answered by @keydunov 😀

Copy link
Member

@hassankhan hassankhan left a comment

🚀

@rpaik rpaik merged commit 4f988f0 into master Mar 19, 2021
3 checks passed
3 checks passed
@github-actions
Build
Details
License Compliance All checks passed.
Details
@netlify
netlify/cubejs-docs-staging/deploy-preview Deploy preview ready!
Details
Roadmap 2021 Q1 automation moved this from In progress to Done Mar 19, 2021
@rpaik rpaik deleted the rpaik-patch-readme-discourse branch Mar 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants