The Wayback Machine - https://web.archive.org/web/20200909220929/https://github.com/dotnet/spark/pull/512
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to a more recent Arcade SDK #512

Merged
merged 1 commit into from May 7, 2020

Conversation

@riarenas
Copy link
Member

riarenas commented May 7, 2020

We are excited to review your PR.

So we can do the best job, please check:

  • There's a descriptive title that will make sense to other developers some time from now.
  • There's associated issues. All PR's should have issue(s) associated - unless a trivial self-evident change such as fixing a typo. You can use the format Fixes #nnnn in your description to cause GitHub to automatically close the issue(s) when your PR is merged.
  • Your change description explains what the change does, why you chose your approach, and anything else that reviewers should know.
  • You have included any necessary tests in the same PR.

This is an update to the latest arcade SDK from the release/3.x branch. This repo was using a version from Sept. 2019.

@imback82 I validated that this should fix your problems from dotnet/arcade#5432

I ran this build with this upgrade arcade version: https://dev.azure.com/dnceng/internal/_build/results?buildId=635224&view=results

and it generated the release packages.

  Successfully created package 'D:\a\1\s\master\artifacts\packages\Release\Shipping\Microsoft.Spark.0.11.0.nupkg'.
  Successfully created package 'D:\a\1\s\master\artifacts\packages\Release\Shipping\Microsoft.Spark.0.11.0.snupkg'.
  Successfully created package 'D:\a\1\s\master\artifacts\packages\Release\Shipping\Microsoft.Spark.Experimental.0.11.0.nupkg'.
  Successfully created package 'D:\a\1\s\master\artifacts\packages\Release\Shipping\Microsoft.Spark.Experimental.0.11.0.snupkg'.
  Successfully created package 'D:\a\1\s\master\artifacts\packages\Release\Shipping\Microsoft.Spark.Extensions.Delta.0.11.0.nupkg'.
  Successfully created package 'D:\a\1\s\master\artifacts\packages\Release\Shipping\Microsoft.Spark.Extensions.Delta.0.11.0.snupkg'.
  Successfully created package 'D:\a\1\s\master\artifacts\packages\Release\Shipping\Microsoft.Spark.Extensions.Azure.Synapse.Analytics.0.11.0.nupkg'.
  Successfully created package 'D:\a\1\s\master\artifacts\packages\Release\Shipping\Microsoft.Spark.Extensions.Azure.Synapse.Analytics.0.11.0.snupkg'
Copy link
Contributor

imback82 left a comment

LGTM, thanks @riarenas!

@imback82 imback82 merged commit 7d87298 into dotnet:master May 7, 2020
2 checks passed
2 checks passed
dotnet.spark Build #20200507.1 succeeded
Details
license/cla All CLA requirements met.
Details
@riarenas riarenas deleted the riarenas:riarenas/test-new-sdk branch May 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.