The Wayback Machine - https://web.archive.org/web/20240920211738/https://github.com/dotnet/spark/pull/704
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CONTRIBUTING.md #704

Merged
merged 2 commits into from
Oct 5, 2020
Merged

Update CONTRIBUTING.md #704

merged 2 commits into from
Oct 5, 2020

Conversation

rapoth
Copy link
Contributor

@rapoth rapoth commented Oct 3, 2020

We are excited to review your PR.

So we can do the best job, please check:

  • There's a descriptive title that will make sense to other developers some time from now.
  • There's associated issues. All PR's should have issue(s) associated - unless a trivial self-evident change such as fixing a typo. You can use the format Fixes #nnnn in your description to cause GitHub to automatically close the issue(s) when your PR is merged.
  • Your change description explains what the change does, why you chose your approach, and anything else that reviewers should know.
  • You have included any necessary tests in the same PR.

This PR is to update the contribution docs to include how to make design changes to the project and how to become a committer.

@rapoth rapoth requested a review from imback82 October 3, 2020 22:53
Copy link
Contributor

@imback82 imback82 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @rapoth!

@imback82 imback82 merged commit 7bcd2a5 into dotnet:master Oct 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants