The Wayback Machine - https://web.archive.org/web/20211026011617/https://github.com/pytorch/pytorch/issues/65431
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not print sccache stats on tests/failed builds #65431

Open
malfet opened this issue Sep 21, 2021 · 1 comment
Open

Do not print sccache stats on tests/failed builds #65431

malfet opened this issue Sep 21, 2021 · 1 comment
Labels
enhancement good first issue module: ci triaged
Projects
PyTorch Dev Infra

Comments

@malfet
Copy link
Contributor

@malfet malfet commented Sep 21, 2021 •
edited by seemethere

When build fails, sccache stats are not relevant
And any time during the testing they are not relevant either (or perhaps should not even been used)

sccache stats output can be found using:

❯ rg '\--show-stats' .jenkins
.jenkins/pytorch/build.sh
252:      sccache --show-stats
254:      sccache --show-stats | python -m tools.stats.upload_sccache_stats

.jenkins/pytorch/win-test-helpers/build_pytorch.bat
138:python setup.py install --cmake && sccache --show-stats && (
154:sccache --show-stats > stats.txt

.jenkins/pytorch/common.sh
101:      sccache --show-stats
110:    ccache --show-stats
112:      ccache --show-stats

.jenkins/caffe2/build.sh
50:    "$SCCACHE" --show-stats

.jenkins/pytorch/win-test-helpers/installation-helpers/install_sccache.bat
5:  %TMP_DIR_WIN%\bin\sccache.exe --show-stats || (

Ideally this would mean only adding the trap command here when running a build job and not a test job:

pytorch/.jenkins/pytorch/common.sh

Line 104 in 7e5aa0d

trap_add sccache_epilogue EXIT

cc @ezyang @seemethere @malfet @pytorch/pytorch-dev-infra
@malfet malfet added this to Needs Triage in PyTorch Dev Infra via automation Sep 21, 2021
@zhouzhuojie zhouzhuojie moved this from Needs Triage to Backlog in PyTorch Dev Infra Sep 27, 2021
@hudsonmendes
Copy link

@hudsonmendes hudsonmendes commented Sep 28, 2021

Dear @malfet - if you give me a bit more information, I could possibly look into this one?
Just how this error shows up in the build failure would be sufficient, much appreciated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement good first issue module: ci triaged
Projects
PyTorch Dev Infra
Backlog
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
@zhouzhuojie @hudsonmendes @malfet