The Wayback Machine - https://web.archive.org/web/20220730185912/https://github.com/gogs/gogs/pull/6553
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docker: check "/data" mount ownership before forcing it #6553

Merged
merged 1 commit into from Mar 11, 2022
Merged

docker: check "/data" mount ownership before forcing it #6553

merged 1 commit into from Mar 11, 2022

Conversation

druppy
Copy link
Contributor

@druppy druppy commented May 10, 2021

Make sure docker start script only force file ownership on /data once.

We use NFS as a data drive and have lots of repositories, and our container times our (in k8s) before it is finish running chown.

This is a small change, without any practical implication except much faster container start.

See #6554

Copy link

@GwynethLlewelyn GwynethLlewelyn left a comment

Seems perfect to me!

Copy link
Member

@unknwon unknwon left a comment

Thank you!

@unknwon unknwon changed the title check /data mount for ownership before forcing it docker: check "/data" mount ownership before forcing it Mar 11, 2022
@unknwon unknwon merged commit 61529fd into gogs:main Mar 11, 2022
@unknwon unknwon mentioned this pull request Mar 18, 2022
27 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants