The Wayback Machine - https://web.archive.org/web/20211125172844/https://github.com/NativeScript/NativeScript/pull/9589
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ios): TextView respect editable binding #9589

Merged
merged 2 commits into from Oct 6, 2021
Merged

fix(ios): TextView respect editable binding #9589

merged 2 commits into from Oct 6, 2021

Conversation

@NathanWalker
Copy link
Contributor

@NathanWalker NathanWalker commented Oct 2, 2021 •
edited
Loading

PR Checklist

What is the current behavior?

<TextView editable="false"/>

Had no effect on edibility thus could not properly disable it.

What is the new behavior?

<TextView editable="false"/>

Now properly disables the TextView to no longer be editable.
@cla-bot cla-bot bot added the cla: yes label Oct 2, 2021
@rigor789 rigor789 merged commit 2b2ce37 into master Oct 6, 2021
2 of 3 checks passed
Loading
@rigor789 rigor789 deleted the fix/textview-ios-editable branch Oct 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rigor789 rigor789

Assignees
No one assigned
Labels
cla: yes hacktoberfest
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
@NathanWalker @rigor789