The Wayback Machine - https://web.archive.org/web/20211221151825/https://github.com/NativeScript/NativeScript/pull/9600

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: android openFile dialog title #9600

Merged

rigor789 merged 2 commits into NativeScript:master from janoshrubos:feat/android-open-file-dialog-title

Oct 6, 2021

Contributor

janoshrubos commented Oct 6, 2021

PR Checklist

The PR title follows our guidelines: https://github.com/NativeScript/NativeScript/blob/master/tools/notes/CONTRIBUTING.md#commit-messages.
There is an issue for the bug/feature this PR is for. To avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it.
You have signed the CLA.
All existing tests are passing: https://github.com/NativeScript/NativeScript/blob/master/tools/notes/DevelopmentWorkflow.md#running-unit-tests-application.
Tests for the changes are included - https://github.com/NativeScript/NativeScript/blob/master/tools/notes/WritingUnitTests.md.

What is the current behavior?

Open File... title is hard coded.

What is the new behavior?

You can change the default Open File... title

Implements #9293

The text was updated successfully, but these errors were encountered:

janoshrubos added 2 commits


          feat: android openFile dialog title

c4a0e67


          types: update openFile types

e71b027

cla-bot bot added the cla: yes label

rigor789 approved these changes

View changes

rigor789 merged commit 77d2533 into NativeScript:master

2 of 3 checks passed

NathanWalker added hacktoberfest hacktoberfest-accepted labels

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment