The Wayback Machine - https://web.archive.org/web/20211026014233/https://github.com/TheAlgorithms/C-Plus-Plus/pull/1584
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create c++_code_fixes #1584

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

Conversation

@Bhagyanekraje
Copy link

@Bhagyanekraje Bhagyanekraje commented Sep 4, 2021

In this file I have written a c++ code to find the reverse of a string without using functions.

Description of Change

Checklist

  • Added description of change
  • Added file name matches File name guidelines
  • Added tests and example, test must pass
  • Added documentation so that the program is self-explanatory and educational - Doxygen guidelines
  • Relevant documentation/comments is changed or added
  • PR title follows semantic commit guidelines
  • Search previous suggestions before making a new one, as yours may be a duplicate.
  • I acknowledge that all my contributions will be made under the project's license.

Notes:

In this file I have written a c++ code to find the reverse of a string without using functions.
Made minor changes in the documentation also changed the return type of main from int to void
Copy link
Member

@mishraabhinn mishraabhinn left a comment

search/linear_search.cpp Outdated Show resolved Hide resolved
mishraabhinn and others added 3 commits Sep 4, 2021
changed the return type of main function from void to int
Sir I thought if the code is not further used for any other purpose then void is best to use.If the piece of code has to be used in any other programs in future then int is best.I have again changed it to int.Do check it.
@mishraabhinn
Copy link
Member

@mishraabhinn mishraabhinn commented Sep 5, 2021

@Bhagyanekraje Please do check the relevant checkbox, and please do refer to the contribution guidelines before commiting. For any question you can ask here or do message your doubts on Gitter Thanks.
Screenshot 2021-09-05 at 12 44 59

Copy link
Author

@Bhagyanekraje Bhagyanekraje left a comment

@Bhagyanekraje Please do check the relevant checkbox, and please do refer to the contribution guidelines before commiting. For any question you can ask here or do message your doubts on Gitter Thanks.
Screenshot 2021-09-05 at 12 44 59

ok sir

search/linear_search.cpp Outdated Show resolved Hide resolved
Copy link
Member

@Panquesito7 Panquesito7 left a comment

Hey there! Thank you for submitting a PR! 😄 Sadly, this does not meet our requirements. Check out our repository standards. Please read them carefully and follow them. Let us know if you need any help in our Discord server.

@github-actions
Copy link

@github-actions github-actions bot commented Oct 14, 2021

This pull request has been automatically marked as abandoned because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale label Oct 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants