The Wayback Machine - https://web.archive.org/web/20201026144241/https://github.com/mdbootstrap/perfect-scrollbar/pull/851
Skip to content

/ perfect-scrollbar

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent TypeErrors in IE11 when classList isn't supported for scroll element #851

Open
wants to merge 2 commits into
base: master
from
Open

Prevent TypeErrors in IE11 when classList isn't supported for scroll element #851

wants to merge 2 commits into from

Conversation

@cheeZery
Copy link

@cheeZery cheeZery commented Feb 7, 2019

This PR serves as a simple fix for an issue that could occur in IE when working with SVG elements, see #830.

Unfortunately I wasn't able to successfully run npm test since prettier kept throwing the following error (node v6.16.0).

14 verbose stack Error: [email protected] format:lint: `prettier -l --single-quote --trailing-comma es5 'src/**/*.js'`
14 verbose stack Exit status 1
14 verbose stack     at EventEmitter.<anonymous> (/usr/lib/node_modules/npm/lib/utils/lifecycle.js:255:16)
14 verbose stack     at emitTwo (events.js:106:13)
14 verbose stack     at EventEmitter.emit (events.js:191:7)
14 verbose stack     at ChildProcess.<anonymous> (/usr/lib/node_modules/npm/lib/utils/spawn.js:40:14)
14 verbose stack     at emitTwo (events.js:106:13)
14 verbose stack     at ChildProcess.emit (events.js:191:7)
14 verbose stack     at maybeClose (internal/child_process.js:920:16)
14 verbose stack     at Process.ChildProcess._handle.onexit (internal/child_process.js:230:5)

But I'm pretty confident that my changes shouldn't violate any prettier rules.
cheeZery added 2 commits Feb 7, 2019
@cheeZery
Prevent TypeErrors in IE11 when classList isn't supported for scroll …
a611e89 
…target
@cheeZery
Build dist files after changes
Loading status checks…
f1402e8
@cheeZery
Copy link
Author

@cheeZery cheeZery commented Feb 7, 2019

😒 Apparently I was wrong about prettier..
@mattonit
Copy link
Collaborator

@mattonit mattonit commented Jan 16, 2020

@cheeZery I'm not sure if you're still interested in getting this fixed, but I can merge your PR if you resolve the conflicts
@cheeZery
Copy link
Author

@cheeZery cheeZery commented Feb 29, 2020

@mattonit thanks for your message and that kind offer, and sorry for never returning to this PR in a year's time.. Apparently my fix seems to be not needed anymore, since someone else changed those lines I tried to fix 🤔 Hence the merge conflicts. Or am I wrong? 😊
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
@cheeZery @mattonit
You can’t perform that action at this time.