Formed in 2009, the Archive Team (not to be confused with the archive.org Archive-It Team) is a rogue archivist collective dedicated to saving copies of rapidly dying or deleted websites for the sake of history and digital heritage. The group is 100% composed of volunteers and interested parties, and has expanded into a large amount of related projects for saving online and digital history.
Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upcheck if activeElement.contentDocument is null #971
Conversation
contentDocument can be null if the iframe and the iframe's parent document are not in the same origin. https://developer.mozilla.org/en-US/docs/Web/API/HTMLIFrameElement/contentDocument
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
contentDocument can be null if an iframe and the iframe's parent document are not in the same origin.
I cannot reproduce this on JSFiddle, but I'm getting a bunch of error logs from Sentry on this line.
It started to happen when we've added one tap Google sign in on our website, which depends on an iframe embedding a document from Google.
https://developer.mozilla.org/en-US/docs/Web/API/HTMLIFrameElement/contentDocument
Thank you very much for your contribution! Please make sure the followings
are checked.
npm testto make sure it formats and build successfully