The Wayback Machine - https://web.archive.org/web/20200906050629/https://github.com/brianc/node-postgres/pull/2299/
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 'Error: invalid sslmode value: "true"' in native mode #2299

Open
wants to merge 3 commits into
base: master
from

Conversation

@sundbry
Copy link

sundbry commented Jul 31, 2020

When using PGSSLMODE env in native mode, an invalid database URL string
is constructed with sslmode=true/false.

sundbry added 3 commits Jul 31, 2020
When using PGSSLMODE env in native mode, an invalid database URL string
would be constructed with sslmode=true/false.
@brianc
Copy link
Owner

brianc commented Aug 3, 2020

Hey thanks for this! Is there a way to write a test for this? If not, if you could show an example in code that causes the problem I can write a test to exercise the fix. Either way I'm good - but need to get this under test so we don't regress on it! 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.