The Wayback Machine - https://web.archive.org/web/20211016201531/https://github.com/ethereum/solidity/issues/12081
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Docs] Mismatched Yul optimizer steps lists #12081

Open
3 tasks
hrkrshnn opened this issue Oct 4, 2021 · 3 comments · May be fixed by #12113
Open
3 tasks

[Docs] Mismatched Yul optimizer steps lists #12081

hrkrshnn opened this issue Oct 4, 2021 · 3 comments · May be fixed by #12113
Assignees
@mau211
Labels
difficulty: easy documentation 📖 good first issue
Projects
Solidity

Comments

@hrkrshnn
Copy link
Member

@hrkrshnn hrkrshnn commented Oct 4, 2021 •
edited

Looking at the list of Yul transformations in the documentation, I noticed a few slight differences between the list at https://docs.soliditylang.org/en/latest/yul.html#optimization-step-sequence and the list at https://docs.soliditylang.org/en/latest/internals/optimizer.html#optimizer-steps:

  • In the second list, change FunctionalInliner to ExpressionInliner, just like in the first list.
  • In the second list, change FullFunctionInliner to FullInliner, just like in the first list.
  • Add UnusedFunctionParamterPruner to the first list.

Reported by @acoglio
@hrkrshnn hrkrshnn added this to New issues in Solidity via automation Oct 4, 2021
@mau211
Copy link

@mau211 mau211 commented Oct 4, 2021

Hey, I would Like to take up this issue

@mau211
Copy link

@mau211 mau211 commented Oct 8, 2021

Hi For: Add UnusedFunctionParamterPruner to the first list. The first list reference has

Abbreviation | Full name
What would be the abbreviation for UnusedFunctionParamterPruner.

@hrkrshnn
Copy link
Member Author

@hrkrshnn hrkrshnn commented Oct 8, 2021

@mau211 it's 'p'. You can find it listed in the following file:

solidity/libyul/optimiser/Suite.cpp

Line 251 in b343e13

{UnusedFunctionParameterPruner::name, 'p'},

@cameel cameel changed the title [Docs] Missing references to documentation [Docs] Mismatched Yul optimizer steps lists Oct 8, 2021
@cameel cameel moved this from New issues to In progress in Solidity Oct 8, 2021
@cameel cameel moved this from In progress to Review in progress in Solidity Oct 8, 2021
@mau211 mau211 linked a pull request that will close this issue Oct 12, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mau211 mau211

Labels
difficulty: easy documentation 📖 good first issue
Projects
Solidity
  
Review in progress
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

Fix mismatched Yul optimizer step lists in docs
3 participants
@cameel @hrkrshnn @mau211