The Wayback Machine - https://web.archive.org/web/20240108134113/https://github.com/python/cpython/pull/28722
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-89526: Use instruction offsets in co_lnotab #28722

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

gh-89526: Use instruction offsets in co_lnotab #28722

wants to merge 1 commit into from
+15 −8

Conversation

serhiy-storchaka
Copy link
Member

@serhiy-storchaka serhiy-storchaka commented Oct 4, 2021 •
edited by bedevere-app bot

@serhiy-storchaka serhiy-storchaka added the type-feature A feature request or enhancement label Oct 4, 2021
markshannon
markshannon reviewed Oct 11, 2021
View reviewed changes
Copy link
Member

@markshannon markshannon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should the new co_endlinetable get changed as well?

Lib/importlib/_bootstrap_external.py
@@ -372,7 +374,7 @@ def _write_atomic(path, data, mode=0o666):
# Whenever MAGIC_NUMBER is changed, the ranges in the magic_values array
# in PC/launcher.c must also be updated.

MAGIC_NUMBER = (3460).to_bytes(2, 'little') + b'\r\n'
MAGIC_NUMBER = (3461).to_bytes(2, 'little') + b'\r\n'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've already claimed this, you'll need to use 3462.

Misc/NEWS.d/next/Core and Builtins/2021-10-04-14-26-46.bpo-45363.IptLgf.rst
@@ -0,0 +1,2 @@
The ``co_lnotab`` attribute of the code objects encodes now instruction
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

co_lnotab is computed and deprectated. The table with the data is co_linetable now.

@github-actions
Copy link

This PR is stale because it has been open for 30 days with no activity.

@github-actions github-actions bot added the stale Stale PR or inactive for long period of time. label Nov 11, 2021
@serhiy-storchaka serhiy-storchaka mentioned this pull request Jan 5, 2024
Open
@erlend-aasland erlend-aasland changed the title bpo-45363: Use instruction offsets in co_lnotab gh-89526: Use instruction offsets in co_lnotab Jan 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markshannon markshannon markshannon left review comments

Assignees
No one assigned
Labels
awaiting core review stale Stale PR or inactive for long period of time. type-feature A feature request or enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@serhiy-storchaka @markshannon @the-knights-who-say-ni @ezio-melotti @bedevere-bot