Add Vue context to computed options type (fix #10878) #12218
+1
−1
Conversation
Vue passes the Vue object as the first parameter, which is useful for arrow functions. This change reflects that in the types. Fixes #10878
|
Thank you but this is not exactly what should be passed. What should be passed is the type of the component to get access to other data and computed properties. Note it might not be possible to support fully so the issue might not be really fixable. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Vue passes the Vue object as the first parameter, which is useful for arrow functions. This change reflects that in the types.
Fixes #10878
What kind of change does this PR introduce? (check at least one)
Does this PR introduce a breaking change? (check one)
If yes, please describe the impact and migration path for existing applications:
The PR fulfills these requirements:
devbranch for v2.x (or to a previous version branch), not themasterbranchfix #xxx[,#xxx], where "xxx" is the issue number)If adding a new feature, the PR's description includes:
Other information: