You might want to consider using rectorphp/rector. It can automatically complete and/or correct existing type declaration and even infer type return for functions and add them to your PHPdoc tags.

The rules that might help with this daunting task of typing are in the TypeDeclaration section:

• AddArrayParamDocTypeRector
• AddArrayReturnDocTypeRector
• CompleteVarDocTypePropertyRector
• PropertyTypeDeclarationRector

Good luck!

Ah I wasn't aware it did type inference too, thanks, will definitely try that before wasting anyone's time doing it by hand :)

Hm yeah so I tried rector and the output is just way too wild and inaccurate to be useful, I end up having to double check everything and undo so much that it's really not saving any time IMO. I'm sure it's great at doing other things and it may well help later to convert docblocks to real types once we support php 7.2+.

So back to the OP plan :)

Sorry that it didn't work, I haven't had a chance to test it but I was hoping it could be useful. Good luck then!

Well, Rector might help for next steps (adding type info in methods) once the properties have types. The main issue today is that all types are missing.

@stof do you mean PHP 7.4 style types properties? Because that's a long way out..

As for var annotations as i wrote in the op i did spend time typing all properties throughout the codebase, which should be enough for static analysis and tools like rector. But it seems to do too much magic with other things which isn't desirable IMO. Maybe I'll try to run it again only with one or two very specific rules.

@Seldaek no, I'm not talking about PHP 7.4 typed properties here, just about property types from any source.
But maybe those rector rules actually do too much magic indeed.

Working on src/Composer/Command

Working on DependencyResolver ..
Pool / PoolBuilder .. some issues with PackageInterface vs. BasePackage, using ->id in places "forces" the need for BasePackage as interface are not allowed to hold members.

@imme-emosol make sure you rebase on latest main branch. But otherwise if you still see problems, feel free to switch to require BasePackage.

Maybe it could be handy to make an extra checkbox to indicate if a namespace has been merged?

Nevermind, that is what those icons are for :s

Well, when the PR is referenced, github shows whether it is merged or no (the icon is different). And we cannot have multiple checkboxes per item in a GFM task list.

I'll have a go on some of the tests

I'll work on Question, Repository, Script and Util

I'll try fixing the Command test.

As I see the Fixtures and IO tests has no errors and can be marked as done.

Happy to take a look at Installer, Downloader and DependencyResolver if these aren't taken.

BTW for everyone working on tests, if you see dataProvider methods which PHPStan complains about, I'd say instead of adding types feel free to rename them to provideFoo or fooProvider, which will then make PHPStan ignore the errors. I don't see much point in typing those return values as they're usually super weird nested arrays and not directly called anywhere.

@megubyte all yours, I marked them claimed now.

I'll take a go on Mock test

I'll grap Platform and Plugin tests as well

I'll work on Config and EventDispatcher

I'll go for Package

Alright we are done here, level 6 is now enabled! 🥳

Many many thanks to everyone involved here writing and reviewing PRs, that was a great help!

Now only 770 errors left to level 7 😉 But that'll require some more code cleanups I think and will have to wait a little.