The Wayback Machine - https://web.archive.org/web/20250524175400/https://github.com/RustPython/RustPython/pull/3194
Skip to content

underscore issue on parse_str #3194

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Conversation

eunsung-lim
Copy link

When parssing string to float, strings with underscores need to raise error
ex. "1_e1"

Copy link
Member

@youknowone youknowone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

By this change, you turned a few tests to pass. Removing unittest.expectedFailure from those tests will make your PR pass tests

@youknowone
Copy link
Member

could you run fmt and push it again? cargo fmt --all will work

@youknowone
Copy link
Member

@eunsung-lim will you going to finish this PR? let me know if you don't want anymore.

@DimitrisJim
Copy link
Member

Thanks, not quite sure unfortunately when, but this currently behaves as expected (code currently resides in the Parser repository). Thanks for the PR though!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants