The Wayback Machine - https://web.archive.org/web/20220516125709/https://github.com/electron/windows-installer/pull/343
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: replace AppVeyor with CircleCI Windows support #343

Merged
merged 4 commits into from Jul 8, 2020

Conversation

malept
Copy link
Member

@malept malept commented Jun 19, 2020

Also a small docs fix.

Can an admin fix the AppVeyor config so that AppVeyor only runs when it detects a config file?

Also, the "required" branch checks need to be updated.

@malept malept requested a review from Jun 19, 2020
@erickzhao
Copy link
Member

@erickzhao erickzhao commented Jun 25, 2020

@malept seems like we can't merge this because AppVeyor is still a required check on the repo. 🤯

@malept
Copy link
Member Author

@malept malept commented Jun 25, 2020

@erickzhao yeah, that's another thing that someone with admin rights to the repo needs to update.

@malept malept merged commit e193923 into master Jul 8, 2020
5 of 7 checks passed
@malept malept deleted the circleci-windows branch Jul 8, 2020
@electron-bot
Copy link

@electron-bot electron-bot commented Jul 8, 2020

🎉 This PR is included in version 4.0.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants