[3.9] bpo-39679: Fix singledispatchmethod classmethod/staticmethod bug
#29087
+50
−0
Conversation
This commit fixes a bug in the 3.9 branch where stacking `@functools.singledispatchmethod` on top of `@classmethod` or `@staticmethod` caused an exception to be raised if the method was registered using type-annotations rather than `@method.register(int)`. Tests for this scenario were added to the 3.11 and 3.10 branches in python#29034 and python#29072; this commit also backports those tests to the 3.9 branch.
AlexWaygood
changed the title
singledispatchmethod classmethod/staticmethod bugsingledispatchmethod classmethod/staticmethod bug
|
I'm fairly new to reStructuredText — any idea what's causing the CI failure? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
This commit fixes a bug in the 3.9 branch where stacking
@functools.singledispatchmethodon top of@classmethodor@staticmethodcaused an exception to be raised if the method was registered using
type-annotations rather than
@method.register(int). Tests for this scenariowere added to the 3.11 and 3.10 branches in #29034 and #29072; this commit
also backports those tests to the 3.9 branch.
The solution proposed in this commit partially derives from ideas suggested by Karthikeyan Singaravelan and Dmitry Kulazhenko in the thread on bugs.python.org.
https://bugs.python.org/issue39679
The text was updated successfully, but these errors were encountered: