The Wayback Machine - https://web.archive.org/web/20221223141251/https://github.com/python/cpython/pull/19014

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-30082 Popen: add kwarg to hide process window on Windows #19014

Open

ammgws wants to merge 2 commits into python:main from ammgws:bpo-30082

+60 −9

ammgws commented Mar 15, 2020 •

edited

https://bugs.python.org/issue30082

Before: On Windows, pythonw opens a console window

After: On Windows, pythonw no longer opens a console window if force_hide is set

Test script:

import subprocess

subprocess.run(
    [
        "C:\\WINDOWS\\system32\\WindowsPowerShell\\v1.0\\powershell.exe",
        "-command",
        "Start-Sleep -Seconds 3; notepad.exe",
    ],
    check=True,
    # added in this PR:
    force_hide=True,
)

ammgws requested a review from gpshead as a code owner

the-knights-who-say-ni added the CLA signed label

bedevere-bot added the awaiting review label

ammgws force-pushed the bpo-30082 branch 2 times, most recently from 7d69936 to 031e91c Compare

Author

ammgws commented Mar 16, 2020

Removed unrelated commit

csabella requested a review from a team

Author

ammgws commented Oct 13, 2021

Resolved conflicts due to 23c0fb8

Also, what to do about the news entry?

Member

zooba commented Oct 16, 2021 •

edited

Add a NEWS entry to the Windows section that reads:

Adds new ``force_hide`` argument to :mod:`subprocess` functions.
This passes ``SW_HIDE`` to the new process, which most applications
will use to not display any window even if they normally would.

Author

ammgws commented Oct 16, 2021

Done, cheers!

eryksun reviewed

Lib/subprocess.py Outdated Show resolved Hide resolved

eryksun reviewed

Lib/subprocess.py Outdated Show resolved Hide resolved

Author

ammgws commented Oct 28, 2021

I had a go at updating the docs as well, but I suspect it could be better worded so any layman could understand the differences between the two options.

eryksun reviewed

Doc/library/subprocess.rst Outdated Show resolved Hide resolved

eryksun reviewed

Doc/library/subprocess.rst Outdated Show resolved Hide resolved

eryksun reviewed

Lib/subprocess.py Outdated Show resolved Hide resolved

eryksun reviewed

Lib/subprocess.py Outdated Show resolved Hide resolved

ammgws marked this pull request as draft

ammgws force-pushed the bpo-30082 branch from a8b7153 to bf96260 Compare

ammgws marked this pull request as ready for review

eryksun reviewed

Lib/subprocess.py Show resolved Hide resolved

Author

ammgws commented Oct 30, 2021

cpython/Lib/test/test_os.py

Line 254 in 62bf263

def write_windows_console(self, *args):

This could be replaced with force_hide

ammgws marked this pull request as draft

ammgws marked this pull request as ready for review

eryksun reviewed

Lib/test/test_subprocess.py Outdated Show resolved Hide resolved

eryksun reviewed

Lib/subprocess.py Show resolved Hide resolved

ammgws and others added 2 commits


          Popen: add kwarg to hide process window on Windows

8f134be

Solves bpo-30082


          📜🤖 Added by blurb_it.

b4106e9

ammgws force-pushed the bpo-30082 branch from 7b51e17 to b4106e9 Compare

iMath mannequin mentioned this pull request

hide command prompt when using subprocess.Popen with shell=False on Windows #74268

Open

ezio-melotti removed the CLA signed label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment