The Wayback Machine - https://web.archive.org/web/20221223163600/https://github.com/python/cpython/pull/29127
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-43592: Raise RLIMIT_NOFILE in test.libregrtest #29127

Merged
merged 6 commits into from Oct 22, 2021

Conversation

gpshead
Copy link
Member

@gpshead gpshead commented Oct 21, 2021

On macOS the default is often too low for our testsuite to succeed.

https://bugs.python.org/issue43592

On macOS the default is often too low for our testsuite to succeed.
@gpshead gpshead changed the title Raise RLIMIT_NOFILE in test.regrtest. bpo-43592: Raise RLIMIT_NOFILE in test.regrtest. Oct 21, 2021
@gpshead gpshead added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Oct 21, 2021
@bedevere-bot
Copy link

bedevere-bot commented Oct 21, 2021

🤖 New build scheduled with the buildbot fleet by @gpshead for commit 0fb8030 🤖

If you want to schedule another build, you need to add the "🔨 test-with-buildbots" label again.

@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Oct 21, 2021
Lib/test/libregrtest/main.py Outdated Show resolved Hide resolved
@vstinner
Copy link
Member

vstinner commented Oct 21, 2021

Would it be possible to only raise temporarily the limit for tests using multiprocessing?

@gpshead
Copy link
Member Author

gpshead commented Oct 21, 2021

Would it be possible to only raise temporarily the limit for tests using multiprocessing?

There is no point in doing so. Most OSes run with much higher default limits. There isn't even a good reason for the limit to exist.

Lib/test/libregrtest/main.py Outdated Show resolved Hide resolved
@gpshead gpshead changed the title bpo-43592: Raise RLIMIT_NOFILE in test.regrtest. bpo-43592: Raise RLIMIT_NOFILE in test.libregrtest Oct 22, 2021
@gpshead gpshead merged commit 843b890 into python:main Oct 22, 2021
12 checks passed
@miss-islington
Copy link
Contributor

miss-islington commented Oct 22, 2021

Thanks @gpshead for the PR 🌮🎉.. I'm working now to backport this PR to: 3.9, 3.10.
🐍🍒🤖

@bedevere-bot
Copy link

bedevere-bot commented Oct 22, 2021

GH-29144 is a backport of this pull request to the 3.10 branch.

@bedevere-bot
Copy link

bedevere-bot commented Oct 22, 2021

GH-29145 is a backport of this pull request to the 3.9 branch.

@gpshead gpshead deleted the regrtest-fdlimit-resource branch Oct 22, 2021
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 22, 2021
Raise RLIMIT_NOFILE in test.libregrtest.

On macOS the default is often too low for our testsuite to succeed.

Co-authored by reviewer: Victor Stinner
(cherry picked from commit 843b890)

Co-authored-by: Gregory P. Smith <[email protected]>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 22, 2021
Raise RLIMIT_NOFILE in test.libregrtest.

On macOS the default is often too low for our testsuite to succeed.

Co-authored by reviewer: Victor Stinner
(cherry picked from commit 843b890)

Co-authored-by: Gregory P. Smith <[email protected]>
miss-islington added a commit that referenced this pull request Oct 22, 2021
Raise RLIMIT_NOFILE in test.libregrtest.

On macOS the default is often too low for our testsuite to succeed.

Co-authored by reviewer: Victor Stinner
(cherry picked from commit 843b890)

Co-authored-by: Gregory P. Smith <[email protected]>
miss-islington added a commit that referenced this pull request Oct 22, 2021
Raise RLIMIT_NOFILE in test.libregrtest.

On macOS the default is often too low for our testsuite to succeed.

Co-authored by reviewer: Victor Stinner
(cherry picked from commit 843b890)

Co-authored-by: Gregory P. Smith <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OS-mac tests Tests in the Lib/test dir
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants