The Wayback Machine - https://web.archive.org/web/20211023074417/https://github.com/JSQLParser/JSqlParser/pull/1380
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support alias for UnPivot statement (see discussion #1374) #1380

Merged
merged 1 commit into from Oct 20, 2021
Merged

Support alias for UnPivot statement (see discussion #1374) #1380

merged 1 commit into from Oct 20, 2021

Conversation

@fabriziodelfranco
Copy link
Contributor

@fabriziodelfranco fabriziodelfranco commented Oct 18, 2021

  • Changed JSqlParserCC.jjt file to add the alias to the UnPivot lexical entity.
  • Added Alias to the UnPivot object.
  • Improved SelectDeParser to correctly deparse SubSelect's UnPivot component.
@fabriziodelfranco
Support alias for UnPivot statement (see discussion JSQLParser#1374)
b3cee05 
- Changed JSqlParserCC.jjt file to add the alias to the UnPivot lexical entity.
- Added Alias to the UnPivot object.
- Improved SelectDeParser to correctly deparse SubSelect's UnPivot component.
@manticore-projects
Copy link
Contributor

@manticore-projects manticore-projects commented Oct 18, 2021

Very nice and clean PR, thank you for contributing!
We do look forward to receive more soon. Cheers!

@wumpz wumpz merged commit 0c0c32e into JSQLParser:master Oct 20, 2021
1 check passed
@wumpz
Copy link
Member

@wumpz wumpz commented Oct 20, 2021 •
edited

Sorry, I saw too late, that your PR is already a one-commit size. So I did a squash and merge. Keep that in mind if you are updating your current branch.

@manticore-projects manticore-projects mentioned this pull request Oct 21, 2021
Closed
manticore-projects added a commit to manticore-projects/JSqlParser that referenced this issue Oct 21, 2021
@manticore-projects @manticore-projects
Fixes JSQLParser#1385 and PR#1380
c2c8122 
Add another Alias() Keyword related LOOKAHEAD
Fix a Keyword Spelling Error in the Deparser
Remove UNPIVOT from the PARENTHESIS Deparser, as it was an ugly workaround made obsolete by PR JSQLParser#1380
@manticore-projects manticore-projects mentioned this pull request Oct 21, 2021
Merged
wumpz pushed a commit that referenced this issue Oct 22, 2021
@manticore-projects @manticore-projects
Fixes #1385 and PR#1380 (#1386)
8c1eba2 
Add another Alias() Keyword related LOOKAHEAD
Fix a Keyword Spelling Error in the Deparser
Remove UNPIVOT from the PARENTHESIS Deparser, as it was an ugly workaround made obsolete by PR #1380
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
@fabriziodelfranco @manticore-projects @wumpz