The Wayback Machine - https://web.archive.org/web/20211030124652/https://github.com/dotnet/machinelearning/pull/5977
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SDL fixes. #5977

Merged
merged 4 commits into from Oct 22, 2021
Merged

SDL fixes. #5977

merged 4 commits into from Oct 22, 2021

Conversation

Reviewers

@tannergooding tannergooding

@eerhardt eerhardt

@tarekgh tarekgh

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
@michaelgsharp @eerhardt @tannergooding
@michaelgsharp
Copy link
Member

@michaelgsharp michaelgsharp commented Oct 15, 2021

Minor fixes for sdl.
@michaelgsharp
SDL fixes.
99bca7d
@codecov
Copy link

@codecov codecov bot commented Oct 15, 2021 •
edited

Codecov Report

Merging #5977 (4e89a52) into main (9b28b24) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #5977      +/-   ##
==========================================
- Coverage   68.24%   68.23%   -0.01%     
==========================================
  Files        1143     1143              
  Lines      242869   242869              
  Branches    25388    25388              
==========================================
- Hits       165734   165726       -8     
- Misses      70441    70445       +4     
- Partials     6694     6698       +4
Flag Coverage Δ
Debug 68.23% <100.00%> (-0.01%) ⬇️
production 62.89% <ø> (-0.01%) ⬇️
test 88.62% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...st/Microsoft.Extensions.ML.Tests/UriLoaderTests.cs 92.30% <100.00%> (ø)
....ML.AutoML/PipelineSuggesters/PipelineSuggester.cs 78.74% <0.00%> (-6.30%) ⬇️
src/Microsoft.ML.AutoML/Sweepers/Parameters.cs 84.74% <0.00%> (-0.85%) ⬇️
...StandardTrainers/Standard/LinearModelParameters.cs 65.82% <0.00%> (-0.26%) ⬇️
...rosoft.ML.AutoML/ColumnInference/TextFileSample.cs 65.56% <0.00%> (ø)
src/Microsoft.ML.Maml/MAML.cs 26.90% <0.00%> (+1.52%) ⬆️

@michaelgsharp michaelgsharp requested a review from Oct 15, 2021
@michaelgsharp
Removed FX cop
34a00ba
@michaelgsharp michaelgsharp marked this pull request as ready for review Oct 15, 2021
@michaelgsharp michaelgsharp requested review from eerhardt and tarekgh Oct 18, 2021
eerhardt
eerhardt reviewed Oct 19, 2021
View changes
src/Native/CMakeLists.txt Outdated Show resolved Hide resolved
@michaelgsharp
Fixes from PR comments.
2ba2436
@michaelgsharp
Removed unnecesary /w warnings.
4e89a52
eerhardt
eerhardt approved these changes Oct 21, 2021
View changes
Copy link
Member

@eerhardt eerhardt left a comment

LGTM. Thanks for the follow up here @michaelgsharp.

@michaelgsharp michaelgsharp merged commit 17f795c into dotnet:main Oct 22, 2021
24 checks passed
@michaelgsharp michaelgsharp deleted the sdl-fixes branch Oct 22, 2021
@michaelgsharp michaelgsharp restored the sdl-fixes branch Oct 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment