The Wayback Machine - https://web.archive.org/web/20210102001946/https://github.com/microsoft/frontend-bootcamp/issues/56
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please make your examples accessible #56

Open
7mary4 opened this issue Mar 1, 2019 · 2 comments
Open

Please make your examples accessible #56

7mary4 opened this issue Mar 1, 2019 · 2 comments

Comments

@7mary4
Copy link

@7mary4 7mary4 commented Mar 1, 2019

This is a great course and people will use your examples as a best practice. Please ensure your examples are accessible. For instance, the first exercise has an input that depends on the placeholder attribute instead of a label.
<input class="textfield" placeholder="add todo">

Providing accessible examples will ensure the next generation of developers include it in their work.

@micahgodbolt
Copy link
Member

@micahgodbolt micahgodbolt commented Mar 4, 2019

How do you feel this is not accessible? Narrator has no trouble reading the placeholder text. Adding aria-label would be redundant.

@flexbox
Copy link

@flexbox flexbox commented Mar 4, 2019

@micahgodbolt placeholer are technicaly correct but for real life example they are not the best.
https://www.smashingmagazine.com/2018/06/placeholder-attribute/

I think @7mary4 wanted to add the classic label + input combo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.