The Wayback Machine - https://web.archive.org/web/20211007113134/https://github.com/electron/electron/pull/24832
Skip to content

/ electron Public

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: enable arm64 macOS tests #24832

Merged
merged 2 commits into from Jan 21, 2021
Merged

ci: enable arm64 macOS tests #24832

merged 2 commits into from Jan 21, 2021

Conversation

@jkleinsc
Copy link
Contributor

@jkleinsc jkleinsc commented Aug 4, 2020 •
edited

Description of Change

This PR enables testing of arm64 macOS builds.

Checklist

Release Notes

Notes: none
@jkleinsc jkleinsc requested a review from as a code owner Aug 4, 2020
@jkleinsc jkleinsc force-pushed the enable-arm2-tests branch from fb9983a to 4712a86 Aug 6, 2020
@jkleinsc jkleinsc force-pushed the enable-arm2-tests branch from 0fbb5d8 to 2c21880 Aug 17, 2020
@jkleinsc jkleinsc force-pushed the enable-arm2-tests branch from 947ad8f to a470fa8 Sep 10, 2020
@jkleinsc jkleinsc force-pushed the enable-arm2-tests branch from a470fa8 to 0164ca9 Sep 24, 2020
@jkleinsc jkleinsc requested a review from as a code owner Sep 28, 2020
@jkleinsc jkleinsc force-pushed the enable-arm2-tests branch from 7a04de7 to c9af89c Sep 28, 2020
@jkleinsc jkleinsc removed the wip ⚒ label Sep 29, 2020
@jkleinsc jkleinsc changed the title [WIP] ci: enable arm2 tests ci: enable arm64 macOS tests Sep 29, 2020
@jkleinsc jkleinsc force-pushed the enable-arm2-tests branch 2 times, most recently from 77a5c96 to f224cc1 Oct 19, 2020
@jkleinsc jkleinsc force-pushed the enable-arm2-tests branch 3 times, most recently from 02ff21f to 00f2f92 Nov 4, 2020
@jkleinsc jkleinsc mentioned this pull request Nov 23, 2020
Closed
4 tasks
@jkleinsc jkleinsc force-pushed the enable-arm2-tests branch from 150c344 to 48903f6 Nov 23, 2020
@jkleinsc jkleinsc mentioned this pull request Nov 23, 2020
Merged
3 tasks
@jkleinsc jkleinsc force-pushed the enable-arm2-tests branch from 48903f6 to 8e8ad0b Jan 5, 2021
@jkleinsc jkleinsc force-pushed the enable-arm2-tests branch from 908d9cf to 2556791 Jan 7, 2021
@jkleinsc jkleinsc mentioned this pull request Jan 13, 2021
Closed
3 tasks
@jkleinsc jkleinsc force-pushed the enable-arm2-tests branch from 5914edc to 12510c6 Jan 13, 2021
@jkleinsc jkleinsc mentioned this pull request Jan 14, 2021
Closed
3 tasks
@jkleinsc jkleinsc mentioned this pull request Jan 19, 2021
Closed
3 tasks
@jkleinsc jkleinsc force-pushed the enable-arm2-tests branch from ab4ea78 to d3ac340 Jan 19, 2021
@jkleinsc
ci: enable arm64 macOS tests
8b37da5
@jkleinsc jkleinsc force-pushed the enable-arm2-tests branch from 4d3e40a to 8b37da5 Jan 21, 2021
@jkleinsc
don't test on forked PRs
f67b81f
@jkleinsc
Copy link
Contributor Author

@jkleinsc jkleinsc commented Jan 21, 2021

Merging as CI failure is unrelated to PR changes.

@jkleinsc jkleinsc merged commit 034a792 into master Jan 21, 2021
14 of 16 checks passed
@release-clerk
Copy link

@release-clerk release-clerk bot commented Jan 21, 2021

No Release Notes

@jkleinsc jkleinsc deleted the enable-arm2-tests branch Jan 21, 2021
@jkleinsc jkleinsc mentioned this pull request Apr 15, 2021
Closed
jviotti
jviotti reviewed Jun 8, 2021
View changes
azure-pipelines-arm.yml
@@ -17,6 +17,7 @@ steps:
node script/download-circleci-artifacts.js --buildNum=$CIRCLE_BUILD_NUM --name=dist.zip --dest=$ZIP_DEST
cd $ZIP_DEST
unzip -o dist.zip
xattr -cr Electron.app
Copy link
Contributor

@jviotti jviotti Jun 8, 2021

@jkleinsc What is the reasoning behind clearing the extended attributes here?

Copy link
Contributor Author

@jkleinsc jkleinsc Jun 9, 2021

@jviotti just to make sure the quarantine attribute is removed from the downloaded file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jviotti jviotti

@codebytere codebytere

Assignees
No one assigned
Labels
semver/none
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
@jkleinsc @codebytere @jviotti