The Wayback Machine - https://web.archive.org/web/20211008161421/https://github.com/electron/electron/pull/30612
Skip to content

/ electron Public

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: add nvmrc file #30612

Merged
merged 1 commit into from Aug 19, 2021
Merged

build: add nvmrc file #30612

merged 1 commit into from Aug 19, 2021

Conversation

@MarshallOfSound
Copy link
Member

@MarshallOfSound MarshallOfSound commented Aug 18, 2021

It helps folks with configured shells to automatically use the right version of node

Notes: none
@MarshallOfSound
build: add nvmrc file
b834cf6
zcbenz
zcbenz approved these changes Aug 18, 2021
View changes
Copy link
Member

@zcbenz zcbenz left a comment

We actually had a .node-version file that got deleted eventually: #12304.

@MarshallOfSound MarshallOfSound merged commit 7093cd7 into main Aug 19, 2021
12 of 15 checks passed
@MarshallOfSound MarshallOfSound deleted the nvmrc branch Aug 19, 2021
@release-clerk
Copy link

@release-clerk release-clerk bot commented Aug 19, 2021

No Release Notes

BlackHole1 added a commit to BlackHole1/electron that referenced this issue Aug 30, 2021
@MarshallOfSound @BlackHole1
build: add nvmrc file (electron#30612)
99b2ad1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zcbenz zcbenz

@VerteDinde VerteDinde

Assignees
No one assigned
Labels
no-backport semver/none
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
@MarshallOfSound @zcbenz @VerteDinde