The Wayback Machine - https://web.archive.org/web/20210918193721/https://github.com/laravel/laravel/pull/5615
Skip to content

/ laravel Public

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add folders to gitignore #5615

Merged
merged 2 commits into from May 24, 2021
Merged

Add folders to gitignore #5615

merged 2 commits into from May 24, 2021

Conversation

@mic-oliveira
Copy link
Contributor

@mic-oliveira mic-oliveira commented May 24, 2021

Add folders to gitignore. The same exclusions exist in the laravel / framework gitignore.
@mic-oliveira
add .idea and .vscode to gitignore
758e4df 
Add folders to gitignore. The same exclusions exist in the laravel / framework gitignore.
@mic-oliveira
Merge pull request #1 from mic-oliveira/20210524-add-folders-to-gitig…
76b9a4a 
…nore

add .idea and .vscode to gitignore
@taylorotwell taylorotwell merged commit 131a102 into laravel:8.x May 24, 2021
1 check passed
@jrd-lewis
Copy link
Contributor

@jrd-lewis jrd-lewis commented Jun 13, 2021

Didn't they get removed in bc435e7 with the reasoning they belonged in a global gitignore instead of a project's specific gitignore? 👀

@GrahamCampbell
Copy link
Member

@GrahamCampbell GrahamCampbell commented Jun 14, 2021 •
edited

They should be, but we're sick of getting these PRs almost every week so we caved. :/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@mic-oliveira @jrd-lewis @GrahamCampbell @taylorotwell